Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat(llm): trustchain integration to qr code scan #7545

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Aug 8, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM WS flow

📝 Description

Add the trustchain integration to the qr code scanned for WS
This allow us to import accounts using WS scanning LLD qr code with LLM

After a scan => pin code :

  • if wrong => error screen on LLD and LLM
  • if good => activation screen on LLD and LLM

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner August 8, 2024 07:31
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 9:03am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 9:03am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 9:03am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 9:03am
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 9:03am

@LucasWerey LucasWerey merged commit 10deab9 into develop Aug 8, 2024
36 of 37 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-12168-b branch August 8, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants