Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet Sync - Non imported accounts Unit Tests #7528

Merged

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Aug 6, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Added unit tests to the live-wallet package to cover the non imported accounts from the accounts module

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 9, 2024 8:13am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:13am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:13am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:13am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:13am

Base automatically changed from support/create-wallet-sync-watch-loop-unit-tests to develop August 6, 2024 14:39
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Aug 6, 2024

Desktop Bundle Checks

Comparing 37fc60e against bd1b099.

βœ… Previous issues have all been fixed.

Mobile Bundle Checks

Comparing 37fc60e against 9c2f1b3.

βœ… Previous issues have all been fixed.

@cgrellard-ledger cgrellard-ledger force-pushed the support/test-wallet-sync-non-imported-accounts branch from 182a7e8 to 37fc60e Compare August 9, 2024 08:08
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review August 9, 2024 08:08
@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner August 9, 2024 08:08
@cgrellard-ledger cgrellard-ledger merged commit 1353e7a into develop Aug 9, 2024
55 of 58 checks passed
@cgrellard-ledger cgrellard-ledger deleted the support/test-wallet-sync-non-imported-accounts branch August 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants