✨feat(llm): add scan WS qr code #7512

LucasWerey · 2024-08-05T16:02:14Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- WS flow

📝 Description

Add the scan of LLD WS Qr code.
Change numbered list to fit with designs

Screen.Recording.2024-08-06.at.10.34.54.mov

❓ Context

JIRA or GitHub link: LIVE-12168

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-08-05T16:02:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Aug 7, 2024 0:59am
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Aug 7, 2024 0:59am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Aug 7, 2024 0:59am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Aug 7, 2024 0:59am
web-tools	⬜️ Ignored (Inspect)	Visit Preview	Aug 7, 2024 0:59am

live-github-bot · 2024-08-05T16:20:01Z

Mobile Bundle Checks

Comparing d39dde4 against 641cc17.

✅ Previous issues have all been fixed.

mcayuelas-ledger · 2024-08-06T08:47:49Z

apps/ledger-live-mobile/src/components/RequiresCameraPermissions/Fallback.tsx

 }: Props) => {
  const { colors } = useTheme();

  return (
-    <Flex flex={1} bg="background.main" px={6}>
+    <Flex flex={1} bg={hasNoBackground ? null : "background.main"} px={6}>


"transparent" ?

apps/ledger-live-mobile/src/components/RequiresCameraPermissions/index.tsx

mcayuelas-ledger · 2024-08-06T08:51:02Z

.../ledger-live-mobile/src/newArch/features/WalletSync/components/Synchronize/ScanTargetSvg.tsx

What is it ?

You can it in package Icons ?

That's the svg for the camera border not an Icon
It's already used for the original camera I've just duplicated it here and remove some parts of the svg

mcayuelas-ledger · 2024-08-06T08:51:58Z

apps/ledger-live-mobile/src/newArch/features/WalletSync/screens/Activation/ActivationDrawer.tsx

@@ -41,11 +40,12 @@ function View({
        hasBackButton={canGoBack}
        onBack={goBackToPreviousStep}
      >
-        <Flex maxHeight={maxDrawerHeight}>
+        <Flex maxHeight={"90%"}>


Why not 100%, even with 100% you still have a gap between top of screen if I'm correct

Not on some devices (with last iphones and the top bar it doesn't work)

mcayuelas-ledger · 2024-08-06T14:03:19Z

it should be like that

LucasWerey · 2024-08-06T14:51:00Z

it should be like that

@mcayuelas-ledger changed

mcayuelas-ledger · 2024-08-07T08:50:23Z

.../ledger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/components/StepFlow.tsx

+  const onQrCodeScanned = (data: string) => {
+    // eslint-disable-next-line no-console
+    console.log(data);
+    // setCurrentStep(Steps.PinCodeInput);
+  };


Fixed in next PR :)

The base branch was changed.

cgrellard-ledger · 2024-08-07T09:33:07Z

It looks weird with the corners inside of the black square instead of how it looks in the figma (at least we could put the same border radius on the black square and on the corners so it doesn't overflow)

LucasWerey · 2024-08-07T09:37:11Z

It looks weird with the corners inside of the black square instead of how it looks in the figma (at least we could put the same border radius on the black square and on the corners so it doesn't overflow)

Yes I know but in Android the camera can't be rounded so I need to see with Cédric what is the best solution

cgrellard-ledger · 2024-08-07T09:38:38Z

apps/ledger-live-mobile/src/newArch/features/WalletSync/components/Synchronize/QrCode.tsx

+  const { t } = useTranslation();
+
+  const QRSize = Math.round(width - 48);
+  const maxQRCodeSize = 280 - 15.36 * 2;


What's this 15.36 ?

It has been done in previous PR I need to rebase

cgrellard-ledger · 2024-08-07T09:39:10Z

apps/ledger-live-mobile/src/newArch/features/WalletSync/components/Synchronize/QrCode.tsx

+        maxWidth={280}
+        maxHeight={280}
+        borderRadius={11.52}
+        background={"#fff"}


Can we use the design system constant.white instead ?

It has been done in previous PR I need to rebase

LucasWerey · 2024-08-07T10:29:47Z

It looks weird with the corners inside of the black square instead of how it looks in the figma (at least we could put the same border radius on the black square and on the corners so it doesn't overflow)

Yes I know but in Android the camera can't be rounded so I need to see with Cédric what is the best solution

@cgrellard-ledger

I think it's better like that also it works for android that way

✨feat(llm): import account flow change ✨feat(llm): add back arrow to queued drawer ✨feat(llm): rework activation flow ✨feat(llm): clean ✨feat(llm): change walletsync to ledgersync for tracking ✨feat(llm): add qr code drawer from manage ws ✨feat(llm): refactor of ws setting inte test ✨feat(llm): rework activation flow ✨feat(llm): change walletsync to ledgersync for tracking ✨feat(llm): add scan WS qr code

LucasWerey requested a review from a team as a code owner August 5, 2024 16:02

github-actions bot assigned LucasWerey Aug 5, 2024

live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Aug 5, 2024

LucasWerey force-pushed the feat/LIVE-12167 branch from f5f105d to 20a52d7 Compare August 5, 2024 16:09

LucasWerey force-pushed the feat/LIVE-12168 branch from 25321b5 to b2aaec1 Compare August 6, 2024 07:34

live-github-bot bot added the ui Has changes in the design system library label Aug 6, 2024

LucasWerey force-pushed the feat/LIVE-12168 branch 2 times, most recently from 53ec55b to ceb3409 Compare August 6, 2024 07:43

live-github-bot bot removed the ui Has changes in the design system library label Aug 6, 2024

LucasWerey force-pushed the feat/LIVE-12168 branch 3 times, most recently from bbf095b to ba9af29 Compare August 6, 2024 08:42

mcayuelas-ledger reviewed Aug 6, 2024

View reviewed changes

LucasWerey force-pushed the feat/LIVE-12168 branch 2 times, most recently from 2c87ba4 to 3380503 Compare August 6, 2024 09:14

LucasWerey force-pushed the feat/LIVE-12168 branch from 3380503 to d8eee1b Compare August 6, 2024 14:50

LucasWerey mentioned this pull request Aug 7, 2024

✨feat(llm): show WS qr code / pincode #7467

Merged

3 tasks

mcayuelas-ledger reviewed Aug 7, 2024

View reviewed changes

mcayuelas-ledger previously approved these changes Aug 7, 2024

View reviewed changes

Base automatically changed from feat/LIVE-12167 to develop August 7, 2024 09:20

cgrellard-ledger reviewed Aug 7, 2024

View reviewed changes

LucasWerey force-pushed the feat/LIVE-12168 branch from d8eee1b to d0735fe Compare August 7, 2024 09:51

cgrellard-ledger previously approved these changes Aug 7, 2024

View reviewed changes

LucasWerey dismissed cgrellard-ledger’s stale review via 1f98155 August 7, 2024 10:30

LucasWerey force-pushed the feat/LIVE-12168 branch 5 times, most recently from f420e83 to 45bd697 Compare August 7, 2024 12:37

cgrellard-ledger previously approved these changes Aug 7, 2024

View reviewed changes

LucasWerey dismissed cgrellard-ledger’s stale review via d39dde4 August 7, 2024 12:57

LucasWerey force-pushed the feat/LIVE-12168 branch from 45bd697 to d39dde4 Compare August 7, 2024 12:57

cgrellard-ledger approved these changes Aug 7, 2024

View reviewed changes

LucasWerey merged commit 7781e20 into develop Aug 8, 2024
35 of 43 checks passed

LucasWerey deleted the feat/LIVE-12168 branch August 8, 2024 07:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨feat(llm): add scan WS qr code #7512

✨feat(llm): add scan WS qr code #7512

LucasWerey commented Aug 5, 2024 •

edited

Loading

vercel bot commented Aug 5, 2024 •

edited

Loading

live-github-bot bot commented Aug 5, 2024 •

edited

Loading

mcayuelas-ledger Aug 6, 2024

mcayuelas-ledger Aug 6, 2024

LucasWerey Aug 6, 2024 •

edited

Loading

mcayuelas-ledger Aug 6, 2024

LucasWerey Aug 6, 2024

mcayuelas-ledger commented Aug 6, 2024

LucasWerey commented Aug 6, 2024 •

edited

Loading

mcayuelas-ledger Aug 7, 2024

cgrellard-ledger commented Aug 7, 2024 •

edited

Loading

LucasWerey commented Aug 7, 2024

cgrellard-ledger Aug 7, 2024

LucasWerey Aug 7, 2024

cgrellard-ledger Aug 7, 2024

LucasWerey Aug 7, 2024

LucasWerey commented Aug 7, 2024

✨feat(llm): add scan WS qr code #7512

✨feat(llm): add scan WS qr code #7512

Conversation

LucasWerey commented Aug 5, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Aug 5, 2024 • edited Loading

live-github-bot bot commented Aug 5, 2024 • edited Loading

Mobile Bundle Checks

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LucasWerey Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcayuelas-ledger commented Aug 6, 2024

LucasWerey commented Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

cgrellard-ledger commented Aug 7, 2024 • edited Loading

LucasWerey commented Aug 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LucasWerey commented Aug 7, 2024

LucasWerey commented Aug 5, 2024 •

edited

Loading

vercel bot commented Aug 5, 2024 •

edited

Loading

live-github-bot bot commented Aug 5, 2024 •

edited

Loading

LucasWerey Aug 6, 2024 •

edited

Loading

LucasWerey commented Aug 6, 2024 •

edited

Loading

cgrellard-ledger commented Aug 7, 2024 •

edited

Loading