Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/filecoin evm #7414

Merged
merged 36 commits into from
Aug 16, 2024
Merged

Support/filecoin evm #7414

merged 36 commits into from
Aug 16, 2024

Conversation

hzheng-ledger
Copy link
Contributor

@hzheng-ledger hzheng-ledger commented Jul 24, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Add ERC20 token support for filecoin network. Adds new tokens specific to filecoin and enable send/receive.

It is a duplication PR of zondax: #6704

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hzheng-ledger hzheng-ledger requested review from a team as code owners July 24, 2024 13:57
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 7:24am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 7:24am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 7:24am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 7:24am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 7:24am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Jul 24, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jul 24, 2024

Mobile Bundle Checks

Comparing 1d8a113 against d60a022.

⚠️ main.ios.jsbundle bundle size significantly increased: 63.5mb -> 63.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 63.5mb -> 63.7mb. Please check if this is expected.

Desktop Bundle Checks

Comparing 1d8a113 against d60a022.

⚠️ renderer bundle size significantly increased: 41.2mb -> 41.3mb. Please check if this is expected.
🚀 @noble/hashes/blake2b library is no longer duplicated in renderer

Copy link

socket-security bot commented Aug 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network Transitive: eval, unsafe +40 11 MB hugomrdias

🚮 Removed packages: npm/[email protected]

View full report↗︎

@hzheng-ledger hzheng-ledger merged commit 5758950 into develop Aug 16, 2024
57 of 61 checks passed
@hzheng-ledger hzheng-ledger deleted the support/filecoin-evm branch August 16, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants