Skip to content

Commit

Permalink
tests(fil): add integration tests for subaccounts
Browse files Browse the repository at this point in the history
  • Loading branch information
@lawRathod
lawRathod committed Apr 24, 2024
1 parent 74a0357 commit db76776
Show file tree
Hide file tree
Showing 6 changed files with 216 additions and 43 deletions.
3 changes: 0 additions & 3 deletions apps/ledger-live-desktop/static/i18n/en/app.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5485,9 +5485,6 @@
"QuantityNeedsToBePositive": {
"title": "The quantity needs to be greater than 0"
},
"RecipientAccountIdNotAvailable": {
"title": "Recipient account id not available on the network"
},
"RPCHostRequired": {
"title": "Host is required."
},
Expand Down
95 changes: 91 additions & 4 deletions libs/ledger-live-common/src/families/filecoin/__snapshots__/bridge.integration.test.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ exports[`filecoin currency bridge scanAccounts filecoin seed 1 1`] = `
"used": true,
},
{
"balance": "0",
"balance": "10000000000000000",
"currencyId": "filecoin",
"derivationMode": "glif",
"freshAddress": "f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia",
Expand All @@ -85,16 +85,29 @@ exports[`filecoin currency bridge scanAccounts filecoin seed 1 1`] = `
"index": 1,
"name": "Filecoin 2",
"nfts": undefined,
"operationsCount": 0,
"operationsCount": 1,
"pendingOperations": [],
"seedIdentifier": "04ca7b02cafdf36e8b4caaf530a96b949764af71b956b2a3328b7a10940794c860f574a9199be98bde3c261887fec8e5fd94bc5f104908bf5f992f52ef2a89abb0",
"spendableBalance": "0",
"spendableBalance": "10000000000000000",
"starred": false,
"subAccounts": [],
"swapHistory": [],
"syncHash": undefined,
"unitMagnitude": 18,
"used": false,
"used": true,
},
{
"approvals": undefined,
"balance": "12340000000000000",
"id": "js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:glif+filecoin%2Ferc20%2Fwrapped~!underscore!~fil",
"operationsCount": 1,
"parentId": "js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:glif",
"pendingOperations": [],
"spendableBalance": "12340000000000000",
"starred": false,
"swapHistory": [],
"tokenId": "filecoin/erc20/wrapped_fil",
"type": "TokenAccountRaw",
},
{
"balance": "0",
Expand Down Expand Up @@ -231,6 +244,33 @@ exports[`filecoin currency bridge scanAccounts filecoin seed 1 1`] = `
"unitMagnitude": 18,
"used": false,
},
{
"balance": "0",
"currencyId": "filecoin",
"derivationMode": "glif",
"freshAddress": "f1347zfz7jiz3oeufp2lrbcwwt265ejk32n2wqrla",
"freshAddressPath": "44'/461'/0'/0/7",
"freshAddresses": [
{
"address": "f1347zfz7jiz3oeufp2lrbcwwt265ejk32n2wqrla",
"derivationPath": "44'/461'/0'/0/7",
},
],
"id": "js:2:filecoin:f1347zfz7jiz3oeufp2lrbcwwt265ejk32n2wqrla:glif",
"index": 7,
"name": "Filecoin 8",
"nfts": undefined,
"operationsCount": 0,
"pendingOperations": [],
"seedIdentifier": "04ca7b02cafdf36e8b4caaf530a96b949764af71b956b2a3328b7a10940794c860f574a9199be98bde3c261887fec8e5fd94bc5f104908bf5f992f52ef2a89abb0",
"spendableBalance": "0",
"starred": false,
"subAccounts": [],
"swapHistory": [],
"syncHash": undefined,
"unitMagnitude": 18,
"used": false,
},
]
`;

Expand Down Expand Up @@ -284,6 +324,53 @@ exports[`filecoin currency bridge scanAccounts filecoin seed 1 2`] = `
"value": "100000000000000000",
},
],
[
{
"accountId": "js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:glif",
"blockHash": null,
"blockHeight": 3853241,
"contract": undefined,
"extra": {},
"fee": "0",
"hasFailed": false,
"hash": "bafy2bzacecwvvvxtlbm5s6wpk546r66hjqw4amjioihe2rt5ufoebu3zv6xiw",
"id": "js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:glif-bafy2bzacecwvvvxtlbm5s6wpk546r66hjqw4amjioihe2rt5ufoebu3zv6xiw-IN",
"operator": undefined,
"recipients": [
"f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia",
],
"senders": [
"f1ovlkmtnqji7wrvdpcys3i22c62obbamgokmg35q",
],
"standard": undefined,
"tokenId": undefined,
"type": "IN",
"value": "10000000000000000",
},
],
[
{
"accountId": "js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:glif+filecoin%2Ferc20%2Fwrapped~!underscore!~fil",
"blockHash": null,
"blockHeight": 3853248,
"contract": undefined,
"extra": {},
"fee": "0",
"hash": "bafy2bzaceaw6jxm3bp6rdvtse7k4evsg2zhis3ootn2pe5k3txtxor4efhl7k",
"id": "js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:glif+filecoin%2Ferc20%2Fwrapped~!underscore!~fil-bafy2bzaceaw6jxm3bp6rdvtse7k4evsg2zhis3ootn2pe5k3txtxor4efhl7k-IN",
"operator": undefined,
"recipients": [
"0xFf000000000000000000000000000000002ED783",
],
"senders": [
"0xff000000000000000000000000000000001FDA97",
],
"standard": undefined,
"tokenId": undefined,
"type": "IN",
"value": "12340000000000000",
},
],
[],
[],
[],
Expand Down
144 changes: 120 additions & 24 deletions libs/ledger-live-common/src/families/filecoin/bridge.integration.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@ import "../../__tests__/test-helpers/setup";
import { testBridge } from "../../__tests__/test-helpers/bridge";
import { getAccountBridge } from "../../bridge";
import { decodeAccountId, encodeAccountId, fromAccountRaw } from "../../account";
import { BigNumber } from "bignumber.js";
import { AmountRequired, InvalidAddress, NotEnoughBalance } from "@ledgerhq/errors";
import { InvalidAddress, NotEnoughBalance, AmountRequired } from "@ledgerhq/errors";

import type { DatasetTest, CurrenciesData } from "@ledgerhq/types-live";
import type { Transaction } from "./types";
import { fromTransactionRaw } from "../filecoin/transaction";
import { InvalidRecipientForTokenTransfer } from "./errors";
import { getSubAccount } from "./bridge/utils/utils";
import BigNumber from "bignumber.js";

const SEED_IDENTIFIER = "f1p74d4mlmeyc4agflhjqsnvoyzyfdai7fmkyso2a";
const ACCOUNT_1 = "f1p74d4mlmeyc4agflhjqsnvoyzyfdai7fmkyso2a";
const SEED_IDENTIFIER = "f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia";
const ACCOUNT_1 = "f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia";
const ACCOUNT_2 = "f410fncojwmrseefktoco6rcnb3zv2eiqfli7muhvqma";
const ACCOUNT_3 = "0x689c9b3232210aa9b84ef444d0ef35d11102ad1f";
const ACCOUNT_4 = "f01840380";
Expand All @@ -21,85 +23,90 @@ const filecoin: CurrenciesData<Transaction> = {
name: "filecoin seed 1",
apdus: `
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000000000000
<= 04ca7b02cafdf36e8b4caaf530a96b949764af71b956b2a3328b7a10940794c860f574a9199be98bde3c261887fec8e5fd94bc5f104908bf5f992f52ef2a89abb015017ff83e316c2605c018ab3a6126d5d8ce0a3023e529663170373464346d6c6d657963346167666c686a71736e766f797a796664616937666d6b79736f32619000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c00008001000080000000800000000000000000
<= 04d493dab3ff63d6f0673454f8f6d6adec08db19e8c0298c65cfcace76a10757774afdee518b15a8b82452531bcb7860eefce02a89ef9051037646f5d4d6bd74171501eac14c6468ac13f66f0e0ee3766472c7e98394ab297431356c6175797a646976716a376d33796f623372786d7a6473793775796866666c777968657572699000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c00008001000080000000800000000001000000
<= 040cbb57791d797268e34340565393f8a014ae754026159973fbe46bdcef3b6d28d155f4923256a2beb9bcff3bd39e5066d1c778306f28a2d4faa3a66dbf70453e150148c9b66fef1fce116652099bec6301ced31e56472974316a6465336d33377064376862637a737362676e36797979627a336a7234767368676370696b32619000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c00008001000080000000800000000002000000
<= 04b5d3766bcfe150e887fe08355d8801901957d4f940ac33086b211cbd2879ccdb475765391f6bdc93329670c899e82ec212e9c90912117d002e5f8d4a25d6c6d01501917d45c3017ba05f783d3ff6c88921273a73daac297431736636756c717962706f7166363662356837336d72636a62653435686877766d6f737a6d7a71719000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c00008001000080000000800000000003000000
<= 041e039416e7b916778a6a6fbcb7b3bce298fb46f084ba27b3f584f7fac52410140cbc275974f9dcb03dde23d39940833fca8d2998710323102e87e04a15e249a215019948a798f70a807872e490d53b50bb0315d494632974317466656b70676878626b61687134786573646b7477756633616d6b356a66646468346b613776699000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c00008001000080000000800000000004000000
<= 04eb83d066b4cb200f1632379f73b1ca6bff0fff17111f7e82a89c8433c6226b34139531f184499b333f31dc9937987a5536953eace7d8ba288aadd42d69d78dc01501d42efce0327edbdf975dcadf472de1d97b5003d1297431327178707a79627370336e35376632357a6c70756f6c7062336635766161367261796f68716a719000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c00008001000080000000800000000005000000
<= 0407230f40bade572d4feeec0e3768789860227986e85b01bb4d462c1b517cd2cc5af4ce2097b06fda52176a542ecce4482291b4f6ece48d59fb9b2a1247f2418d1501d981129d32078f65537f1061f28cd00f005fb4832974313367617266686a73613668776b753337636271376664677162346166376e65647272737a6561619000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c00008001000080000000800000000006000000
<= 0466a53388d30f8323cb39ca62cd261a63d43b6f1bbf05250ea7bef8077037ae74bfa6a42f5ef9757e53e713a9695c2de82cad06472385292c63337db0cbd80daa150144b33ed6e4940cce710c70146b8cfd18eb97f85929743169737a74357678657371676d3434696d6f616b67786468356464767a7036637a6b61756f377a799000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080010000800000000000000000
<= 0463c18e9a3c08ecffab4fa384f977e5d380d2b252dbbd96875df9cc91c44c81e82639fd659a3eeeaed96901696d8c7832b03befafd0af6ab2bee634ea8141e52a15016f62da10a416f416e80ec32866b91f01f7746af82966316e35726e75656665633332626e32616f796d75676e6f693761683378693278796e766c746e71699000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080020000800000000000000000
<= 04f838a8b60e8c8ddaa40b164c458b32094be15606c261008fbb4a38d9d7fd63d0b3343f1e0b861b142774fa242234185f79d95e180609bf6c56ad38f36197bf3715010b485688119885d1fa4a27d026c7f30531a62936296631626e65666e636172746363356436736b653769636e723774617579326d6b6a7732796e676275799000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080030000800000000000000000
<= 04e3493fab64823760f42c5fca00dc27a3eb9cb8ba0b52c498b940a7ec82bad70f8b68bd2c7d6cc4074eb08d24187d925fab1fa54dbe7c26f544fd53b454ebcacd1501188ac818a6471dc0c43deef4cc4fb3594a85885d2966316463666d7167666769346f34627262353533326d797435746c6666696c6363353236637a7578699000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080040000800000000000000000
<= 04851093dcfb51ae7eb3a085003c50a2f6ee635cc7192b713bd5d89301c1ce38d6ee44ec601b0c67218f502dfd7bc8bc96014e1db2f3754552507a5c313ebe0e2c1501ac247d637e126ed294b6761bf3877bda8f04d9002966317671736832793336636a786e666666776f796e3768623333336b68716a7769616b7a63616e32799000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080050000800000000000000000
<= 04368d7fe53c84f52574cb0f9b0a78dcddf37d1b1e09e9c8a7bfab2e9bf06ce71a7ab0f453b938ffa093d1c8028b159bad8727b71a6508acbc2d530eb45ff9dab51501ec13e2bf751dd038dceb18db8447699bc67a3d6c29663135716a3666703376647869647278686c64646e796972336a7470646875706c6d6f656f717463699000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080060000800000000000000000
<= 0418de25cee71d38de134e9fede2c42c28c5a8b06a4643527fe61ac272e45e562d957b18d85364da0cce8ffb470a30dba6e1d56f68cbaffc25f2332932731227991501a223f50f49d9804314bd96636ae7f5267360aeb2296631756972376b64326a3367616567666635737a7277767a3776657a7a77626c7673776669347974699000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000001000000
<= 0419d91b4f9c3015637f5aa6b601b337f2770b1dcf93ba896d64627cd2aa67493ba924decd3024643478a84e06486b0a6b10d9f7607b6e92b0545bb3c998d4d75d15017ad86da94bab1ae1942e43050edb5f634b2d1ec9296631706c6d67336b6b6c766d6e6f6466626f696d6371357732376d6e66733268776a746173366769619000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000002000000
<= 047fc6dc24f9c4bb243023b760637fc604c492da6406824f22592d96a4f435767c975d675b5aef0e160f87d2950860c50e2ab691f197033d234ce7af61fcded4b01501eb4fc162c42bfcf0572941424d3a2c603fc60176296631356e6834637977656670367061767a6a69666265326f726d6d6137346d616c77647979357266719000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000003000000
<= 04b5a4495a2edc7d6e121715332fcac13a28e1167c702d0a3ddbb5a5ff9027182db0a4c94387ee5c9cdd53fb7474b968a9f1310225c02c375d10189b4fc5e1f24a150159b7be7dd3ba42bb42fe7b60d83b3c142c0943bf2966316c67333334376f74786a626c77717836706e716e716f7a346371776173713537796f32627863799000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000004000000
<= 04b479cb2a3d8fe60534943f3bfad0e55ba4283d31974581e8d348623aeb4a3e15c8167a003c92dcf52e12ee253126faebc7d445bce8e347bdd26d8a2e53a46b3315014ea8e251c8a4987d19c35e3854547e33988f024c2966316a32756f65756f6975736d6832676f646c79346669766436676f6d693661736d7a6b6434376c699000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000005000000
<= 04a2dc85c8669642342c476dfd7a85f23309c7c06df209ed6846815786a6740ab35f8b9024b1616780a39dea7a9e7a05b8e808539688f70ad1ad814889546e738815015fcfe6d5c16405f00e1f7ae60ea9bfb8173bf95e2966316c3768366e766f626d71633761647137706c7461356b6e3778616c7478366b366c3770617173719000
=> 0600000000
<= 0000170800311000049000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000006000000
<= 045d4460005b5218e70aac7e6d1d8980b24fae39c743fa50b2cfd0dd062b5f88ea27ea5fe614ff059e0a62691bb91774dea71f5b8c0bf57703688a05e1bb0b436a150146871b490baefaf7ffa3a8fba2357b71e005501a296631693264727773696c763335707037356476643532656e6c336f6871616b7561326d7368663566799000
=> 0600000000
<= 0000180100331000049000
=> 06010000142c000080cd010080000000800000000007000000
<= 0453fd3f49647650ba84cf7016e370a7f26a2b19684fc90c0e669ea1f7120ef4fb812c6b8e9e8fc9bf9d20b02109064482742c478e275851a181eb1bb24ac0b1ae1501df3f92e7e94676e250afd2e2115ad3d7ba44ab7a2966313334377a667a376a697a336f65756670326c726263777774323635656a6b33326e327771726c619000
`,
},
],
Expand Down Expand Up @@ -301,6 +308,95 @@ const filecoin: CurrenciesData<Transaction> = {
};
},
},
// Subaccout tests
{
name: "Subaccount erc20 transfer",
transaction: fromTransactionRaw({
family: "filecoin",
method: 1,
version: 1,
nonce: 100,
gasFeeCap: "1000",
gasLimit: 10,
gasPremium: "10000",
recipient: ACCOUNT_4,
amount: "10",
subAccountId:
"js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:+filecoin%2Ferc20%2Fwrapped~!underscore!~fil",
}),
expectedStatus: {
errors: {},
warnings: {},
},
},
{
name: "Subaccount Send to unsupported address",
transaction: fromTransactionRaw({
family: "filecoin",
method: 1,
version: 1,
nonce: 100,
gasFeeCap: "1000",
gasLimit: 10,
gasPremium: "10000",
recipient: ACCOUNT_1,
amount: "10000",
subAccountId:
"js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:+filecoin%2Ferc20%2Fwrapped~!underscore!~fil",
}),
expectedStatus: {
errors: {
recipient: new InvalidRecipientForTokenTransfer(),
},
},
},
{
name: "Subaccount Send max",
transaction: fromTransactionRaw({
family: "filecoin",
method: 1,
version: 1,
nonce: 100,
gasFeeCap: "1000",
gasLimit: 10,
gasPremium: "10000",
recipient: ACCOUNT_2,
amount: "1",
useAllAmount: true,
subAccountId:
"js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:+filecoin%2Ferc20%2Fwrapped~!underscore!~fil",
}),
expectedStatus: (account, tx) => {
const subAccount = getSubAccount(account, tx);
return {
amount: subAccount?.spendableBalance,
errors: {},
warnings: {},
};
},
},
{
name: "Subaccount not enough balance",
transaction: fromTransactionRaw({
family: "filecoin",
method: 1,
version: 1,
nonce: 100,
gasFeeCap: "1000",
gasLimit: 10,
gasPremium: "10000",
recipient: ACCOUNT_3,
amount: "123400000000000000",
subAccountId:
"js:2:filecoin:f1plmg3kklvmnodfboimcq5w27mnfs2hwjtas6gia:+filecoin%2Ferc20%2Fwrapped~!underscore!~fil",
}),
expectedStatus: {
errors: {
amount: new NotEnoughBalance(),
},
warnings: {},
},
},
],
},
],
Expand Down
7 changes: 2 additions & 5 deletions libs/ledger-live-common/src/families/filecoin/bridge/utils/addresses.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
import { log } from "@ledgerhq/logs";
import BigNumber from "bignumber.js";
import { fetchEthAddrForF1Fil } from "./api";
import { RecipientAccountIdNotAvailable } from "../../errors";

export type ValidateAddressResult =
| {
Expand Down Expand Up @@ -86,8 +85,8 @@ export const convertAddressFilToEth = async (addr: string): Promise<string> => {
switch (recipientAddressProtocol) {
case "f1": {
const res = await fetchEthAddrForF1Fil(addr);
if (res == "") {
throw new RecipientAccountIdNotAvailable();
if (!res) {
throw new Error("recipient account id not available on the network");
}
return res;
}
Expand All @@ -104,6 +103,4 @@ export const convertAddressFilToEth = async (addr: string): Promise<string> => {
throw new Error("supported address protocols are f0, f1, f4");
}
}

return addr;
};
Loading

0 comments on commit db76776

Please sign in to comment.