Bugfix/Live-13301 tezos min reveal gasfees (#7532)

fix: tezos min reveal gaslimit
LedgerHQ · Aug 8, 2024 · b97b76c · b97b76c
1 parent 1690fc9
commit b97b76c
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/dry-oranges-hammer.md b/.changeset/dry-oranges-hammer.md
@@ -0,0 +1,6 @@
+---
+"@ledgerhq/coin-tezos": patch
+"@ledgerhq/live-common": patch
+---
+
+fix tezos min reveal gaslimit
diff --git a/libs/coin-modules/coin-tezos/src/api/index.integ.test.ts b/libs/coin-modules/coin-tezos/src/api/index.integ.test.ts
@@ -22,6 +22,7 @@ describe("Tezos Api", () => {
       },
       fees: {
         minGasLimit: 600,
+        minRevealGasLimit: 300,
         minStorageLimit: 0,
         minFees: 500,
         minEstimatedFees: 500,

diff --git a/libs/coin-modules/coin-tezos/src/config.ts b/libs/coin-modules/coin-tezos/src/config.ts
@@ -13,6 +13,7 @@ export type TezosConfig = {
   };
   fees: {
     minGasLimit: number;
+    minRevealGasLimit: number;
     minStorageLimit: number;
     minFees: number;
     minEstimatedFees: number;

diff --git a/libs/coin-modules/coin-tezos/src/logic/craftTransaction.ts b/libs/coin-modules/coin-tezos/src/logic/craftTransaction.ts
@@ -2,6 +2,7 @@ import { OpKind, type OperationContents } from "@taquito/rpc";
 import { DEFAULT_FEE } from "@taquito/taquito";
 import { UnsupportedTransactionMode } from "../types/errors";
 import { getTezosToolkit } from "./tezosToolkit";
+import coinConfig from "../config";
 
 type TransactionFee = {
   fees?: string;
@@ -43,13 +44,14 @@ export async function craftTransaction(
 
   if (publicKey !== undefined) {
     const revealFees = await tezosToolkit.estimate.reveal();
-
+    const minRevealGasLimit = coinConfig.getCoinConfig().fees.minRevealGasLimit;
+    const revealGasLimit = Math.max(revealFees?.gasLimit || 0, minRevealGasLimit);
     contents.push({
       kind: OpKind.REVEAL,
       fee: DEFAULT_FEE.REVEAL.toString(),
       //TODO: use instead of previous line when this PR will be validated, as the value change (don't forget to update the test too)
       // fee: getRevealFee(address).toString(),
-      gas_limit: (revealFees?.gasLimit || 0).toString(),
+      gas_limit: revealGasLimit.toString(),
       storage_limit: (revealFees?.storageLimit || 0).toString(),
       source: publicKey.publicKeyHash,
       counter: (counter + 1 + contents.length).toString(),

diff --git a/libs/coin-modules/coin-tezos/src/test/config.ts b/libs/coin-modules/coin-tezos/src/test/config.ts
@@ -12,6 +12,7 @@ export const mockConfig = {
   },
   fees: {
     minGasLimit: 0,
+    minRevealGasLimit: 0,
     minStorageLimit: 0,
     minFees: 0,
     minEstimatedFees: 0,

diff --git a/libs/ledger-live-common/src/families/tezos/config.ts b/libs/ledger-live-common/src/families/tezos/config.ts
@@ -20,6 +20,7 @@ export const tezosConfig: Record<string, ConfigInfo> = {
       },
       fees: {
         minGasLimit: 600,
+        minRevealGasLimit: 300,
         minStorageLimit: 0,
         minFees: 500,
         minEstimatedFees: 500,