chore: fix generate-bot-super-report tool

tools/actions/generate-bot-super-report/logic.ts

@@ -2,8 +2,8 @@ import { Parse } from "unzipper";
 import { parser } from "stream-json";
 import { streamValues } from "stream-json/streamers/StreamValues";
 import { delay, retry, promiseAllBatched } from "./promise";
-import fetch from "node-fetch";
 import groupBy from "lodash/groupBy";
+import { Readable } from "stream";
 
 type AppCandidate = {
   path: string;
@@ -41,48 +41,45 @@ export type MinimalSerializedReport = {
 export type Artifact = {
   created_at: string;
   archive_download_url: string;
+  name: string;
+  workflow_run: {
+    head_branch: string;
+  };
 };
 
-function handleErrors(response) {
-  if (!response.ok) {
-    throw Error(response.url + ": " + response.status + " " + response.statusText);
-  }
-  return response;
-}
-
 async function downloadArchive(
   githubToken: string,
   url: string,
 ): Promise<MinimalSerializedReport | null> {
   console.log("retrieving " + url);
-  const blob = await retry(() =>
+
+  const blob: Blob | null = await retry(() =>
     fetch(url, {
       headers: {
         Authorization: `Bearer ${githubToken}`,
         "Content-Type": "application/json",
       },
     }),
-  ).then(r => {
-    if (r.ok) {
-      return r.blob();
-    }
-    if (r.status === 410) {
-      return null;
-    }
-    return handleErrors(r);
-  });
+  )
+    .then(r => {
+      // no more content
+      if (r.status === 410) {
+        return null;
+      }
+    })
+    .then(r => (r ? handleErrors(r) : null))
+    .then(r => (r ? r.blob() : null));
   if (!blob) return null;
   return new Promise((resolve, reject) => {
-    blob
-      .stream()
+    Readable.fromWeb(blob.stream() as any)
       .pipe(Parse())
       .on("entry", entry => {
         const fileName = entry.path;
         if (fileName === "report.json") {
           entry
             .pipe(parser())
             .pipe(streamValues())
-            .on("data", e => resolve(e.value))
+            .on("data", (e: { value: any }) => resolve(e.value))
             .on("error", reject);
         } else {
           entry.autodrain();
@@ -92,17 +89,24 @@ async function downloadArchive(
 }
 
 // true if a is before b
-function isDateBefore(a, b) {
+function isDateBefore(a: string | Date, b: string | Date) {
   return new Date(a) < new Date(b);
 }
 
-function successRateDisplay(a, b) {
+function successRateDisplay(a: number, b: number) {
   if (!b) return "N/A";
   if (!a) return "❌ 0%";
   const r = a / b;
   return (r === 1 ? "✅ " : r < 0.8 ? "⚠️ " : "") + Math.round(100 * r) + "%";
 }
 
+function handleErrors(response: Response) {
+  if (!response.ok) {
+    throw Error(response.url + ": " + response.status + " " + response.statusText);
+  }
+  return response;
+}
+
 export async function loadReports({
   branch,
   days,
@@ -137,7 +141,7 @@ export async function loadReports({
       }),
     )
       .then(r => (r.ok ? r.json() : r.status === 502 ? {} : handleErrors(r)))
-      .then(r => {
+      .then((r: { artifacts?: Artifact[] }) => {
         if (r.artifacts) {
           return r.artifacts;
         }
@@ -450,7 +454,7 @@ function groupSimilarError(str: string): string {
   return str;
 }
 
-function safeErrorDisplay(txt) {
+function safeErrorDisplay(txt: string) {
   return txt.slice(0, 200).replace(/[\s`]/g, " ");
 }
 

tools/actions/generate-bot-super-report/package.json

@@ -13,9 +13,11 @@
   "devDependencies": {
     "@actions/core": "^1.10.1",
     "@actions/github": "^5.1.1",
+    "@types/node": "20",
     "@types/unzipper": "0.10.8",
-    "lodash": "4.17.21",
-    "node-fetch": "^3.3.2",
+    "@types/stream-json": "1.7",
+    "@types/lodash": "4",
+    "lodash": "4",
     "stream-json": "1.8.0",
     "tsup": "^7.0.0",
     "unzipper": "0.10.14"

tools/actions/generate-bot-super-report/tsconfig.json

@@ -0,0 +1,4 @@
+{
+  "extends": "../../../tsconfig.base",
+  "exclude": ["build"]
+}