feature/rating ratings feature flag added #1930

cgrellard-ledger · 2022-05-03T13:47:25Z

Ratings feature flag added

Context (issues, jira)

Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

vercel · 2022-05-03T13:47:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ledger-live-common	❌ Failed (Inspect)		May 3, 2022 at 2:35PM (UTC)

feature/rating ratings feature flag added

b232d79

cgrellard-ledger requested a review from a team as a code owner May 3, 2022 13:47

vercel bot had a problem deploying to Preview May 3, 2022 13:54 Failure

feature/rating comma added

6522c8d

nparigi-ledger approved these changes May 3, 2022

View reviewed changes

vercel bot had a problem deploying to Preview May 3, 2022 14:35 Failure

thomasrogerlux approved these changes May 3, 2022

View reviewed changes

cgrellard-ledger merged commit d65a585 into develop May 3, 2022

cgrellard-ledger deleted the feature/rating branch May 3, 2022 15:46

This was referenced May 5, 2022

Release/22.1.x #1940

Merged

Release/22.1.x #1954

Merged