Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

added dummy app to remoteLiveAppProvider #1815

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

ggilchrist-ledger
Copy link
Contributor

Description / Usage

Adding the Dummy Live app to the RemoteLiveAppProvider so it is available for the discover.spec.ts test.

@ggilchrist-ledger ggilchrist-ledger requested review from IAmMorrow and a team March 15, 2022 14:24
@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/F6CLXZ7TsBQTFmmG69zUVFvp8NaN
✅ Preview: https://ledger-live-common-git-test-add-dummy-app-to-providers-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1815 (7f0b529) into develop (4111ff9) will increase coverage by 3.91%.
The diff coverage is 81.42%.

❗ Current head 7f0b529 differs from pull request most recent head db6dd9c. Consider uploading reports for the commit db6dd9c to get more accurate results

@@             Coverage Diff             @@
##           develop    #1815      +/-   ##
===========================================
+ Coverage    52.23%   56.15%   +3.91%     
===========================================
  Files          528      596      +68     
  Lines        22966    23572     +606     
  Branches      5539     5900     +361     
===========================================
+ Hits         11997    13237    +1240     
+ Misses       10899    10285     -614     
+ Partials        70       50      -20     
Impacted Files Coverage Δ
src/apps/support.ts 31.81% <ø> (-68.19%) ⬇️
src/families/solana/api/traced.ts 75.51% <75.51%> (ø)
src/families/solana/api/chain/index.ts 60.71% <88.88%> (-10.72%) ⬇️
src/cross.ts 82.85% <100.00%> (+69.39%) ⬆️
src/families/solana/bridge/js.ts 100.00% <100.00%> (ø)
src/families/elrond/api/apiCalls.ts 14.28% <0.00%> (-82.86%) ⬇️
src/families/cosmos/js-updateTransaction.ts 20.00% <0.00%> (-80.00%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-76.48%) ⬇️
... and 373 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4111ff9...db6dd9c. Read the comment docs.

Copy link
Contributor

@IAmMorrow IAmMorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀

@valpinkman valpinkman merged commit 8cd8715 into develop Mar 25, 2022
@valpinkman valpinkman deleted the test/add-dummy-app-to-providers branch March 25, 2022 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants