Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B2CA-1684: Port Flex #29

Merged
merged 5 commits into from
Jul 10, 2024
Merged

B2CA-1684: Port Flex #29

merged 5 commits into from
Jul 10, 2024

Conversation

cedelavergne-ledger
Copy link

@cedelavergne-ledger cedelavergne-ledger commented Jun 6, 2024 •
edited
Loading

Flex porting:

  • Migrate to nbglv2
  • Update version
  • Add Flex config

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1684_Port-Flex branch 2 times, most recently from fe7587c to 7cfefb0 Compare July 8, 2024 09:32
tdejoigny-ledger
tdejoigny-ledger previously approved these changes Jul 10, 2024
View reviewed changes
Copy link

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we, at least, remove the deprecated CX_APILEVEL constant (and the linked code) ?

src/ui_nbgl.c Outdated
@@ -20,107 +21,97 @@ static const char* const infoContents[] = {
VERSION
};

static nbgl_layoutSwitch_t switches[3] = {0};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a #define for the switches number (will be reused after)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/ui_nbgl.c Outdated
};

content.type = SWITCHES_LIST;
content.content.switchesList.nbSwitches = 3;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a #define

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cedelavergne-ledger
Copy link
Author

Merging this 1st pass to allow the external dev team to fix remaining Tests issues (and deprecated API calls 😉 )

@cedelavergne-ledger cedelavergne-ledger merged commit 2419c98 into develop Jul 10, 2024
25 of 31 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-1684_Port-Flex branch July 10, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedelavergne-ledger @tdejoigny-ledger