Skip to content

Conversation

@MasWag
Copy link
Contributor

@MasWag MasWag commented Jul 6, 2022

Due to the limitation of OS, long LTL formulas cannot be fed via the command line. This PR modifies to feed LTL formulas via a temporary file so that long LTL formulas can also be fed to LTSMin.

Copy link
Member

@mtf90 mtf90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I only have minor remarks. Could you potentially also provide a test case for such a long formula? Preferably one that crashes with the current version but passes with your changes. Or is this too OS-specific?

MasWag and others added 4 commits February 14, 2023 19:45
* move case in a separate test method
* use a formula that is easier to modelcheck to reduce runtime
@mtf90
Copy link
Member

mtf90 commented Feb 15, 2023

PR looks good to me now. The error in the CI pipeline is related to changes in ADDLib (of which we use a development version currently). I'm already in talks with the developers and will merge this PR once everything is resolved so that we have a nice commit with valid checks.

@mtf90
Copy link
Member

mtf90 commented Feb 15, 2023

The ADDLib related issue has been fixed upstream

@mtf90 mtf90 merged commit 5278418 into LearnLib:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants