-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zapier integration #2577
Merged
Merged
feat: zapier integration #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 - create todo 2 - create milestone 3 - update todo
kylemcshea
commented
Jul 10, 2024
kylemcshea
commented
Jul 10, 2024
kylemcshea
commented
Jul 10, 2024
kylemcshea
commented
Jul 10, 2024
kylemcshea
commented
Jul 10, 2024
kylemcshea
commented
Jul 10, 2024
kylemcshea
commented
Jul 10, 2024
marcelfolaron
requested changes
Jul 10, 2024
…on for update todo action
marcelfolaron
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
Please add a link to the GitHub issue being addressed by this change.
Developer Guide
https://docs.google.com/document/d/1HWamnw-ebKEM60mPL8sLQYJPW8inJHF2a-RSXnIxG5c/edit#heading=h.7jl8tl5k1raa
Description
Please include a short description of the suggested change and the reasoning behind the approach you have chosen.
The intent of this PR is to add the following pieces for a zapier integration:
Triggers
Actions
This was done by utilizing mostly service layer methods that with the proper parameters can be utilized.
With that being said not all service layer methods needed to make these zapier interactions possible are made.
One thing to denote - when checking for an updated artifact since Zapier uses
id
to index objects in a list, what we must do is append it with itslast_updated
dateTime string so that we can detect any differences in theid
indices.So we would end up modifying our returned
id
to be like{id}-{modified_date}
Here is where I derived this decision from:
https://community.zapier.com/how-do-i-3/polling-an-api-for-updated-records-not-just-new-ones-1165
Screenshot of the result
If your change affects the user interface, you should include a screenshot of the result with the pull request.
Checklist
If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer, please add them here.
New Goal will be completed in a seperate PR as the canvas -> canvas item relation makes that task not exactly straight forward