New session handling #2530
Merged
New session handling #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time into newSessionHandling
1 task
pvi-github
reviewed
Jun 21, 2024
| */ | ||
| protected $deferredServices = []; | ||
|
|
||
| protected $serviceProviders = []; |
There was a problem hiding this comment.
Perhaps add an explaining comment for each ?
pvi-github
reviewed
Jun 21, 2024
| */ | ||
| public function __construct() | ||
| { | ||
|
|
|
Has it been tested when php redis modules are not installed ? |
2 tasks
2 tasks
Yes, redis is not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
Various
#2516
#2504
Description
Our custom session handler was outdated and needed to be adjusted. We are now using Laravel's ssession management
Checklist
If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.