Fix content-disposition header #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For downloads with unknown file types (like xls, zip), the content is displayed inline in Chrome. Works fine in Firefox without this change.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For downloads with unknown file types (like xls, zip), the content is displayed inline in Chrome. Works fine in Firefox without this change.
Link to ticket
No ticket. Reported on Cloudron forum at https://forum.cloudron.io/topic/11347/issue-with-file-opening-downloading-in-leantime-application
Description
content-disposition is not set correctly for chrome browser when downloading unknown file types
Screenshot of the result
No change in UI
Checklist
I have only tested this change locally on Cloudron and have not run the tests.
Additional comments or questions
If you have any further comments or questions for the reviewer, please add them here.