Skip to content

Update common/utils and common/primitives to v10.277#2192

Merged
ghost91- merged 8 commits into
League-of-Foundry-Developers:mainfrom
Spice-King:v10/common-utils
Aug 19, 2022
Merged

Update common/utils and common/primitives to v10.277#2192
ghost91- merged 8 commits into
League-of-Foundry-Developers:mainfrom
Spice-King:v10/common-utils

Conversation

@Spice-King
Copy link
Copy Markdown
Contributor

@Spice-King Spice-King commented Aug 14, 2022 •
edited by ghost91-
Loading

Resolves #2172, resolves #2173, resolves #2174, resolves #2175, resolves #2176, resolves #2177, resolves #2218, and touches #2166.

@Spice-King Spice-King requested a review from a team as a code owner August 14, 2022 23:47
Spice-King added a commit to Spice-King/foundry-vtt-types that referenced this pull request Aug 14, 2022
@Spice-King
Update head.d.ts to v10.277, depends on League-of-Foundry-Developers#…
cd0195b 
…2192 for Color
@Spice-King
Copy link
Copy Markdown
Contributor Author

Spice-King commented Aug 14, 2022 •
edited
Loading

url.mjs.d.ts is non-functional due to issues I tried to resolve upstream in Typescript. For the interested, I tried to fix it, but was not able to find a solution I liked for my PR, so I pushed a draft up here: microsoft/TypeScript-DOM-lib-generator#1379

@ghost91-
Copy link
Copy Markdown
Collaborator

ghost91- commented Aug 15, 2022

utils.mjs.d.ts is non-functional due to issues I tried to resolve upstream in Typescript. For the interested, I tried to fix it, but was not able to find a solution I liked for my PR, so I pushed a draft up here: microsoft/TypeScript-DOM-lib-generator#1379

I believe you mean url.mjs.d.ts...?

@Spice-King
Copy link
Copy Markdown
Contributor Author

Spice-King commented Aug 15, 2022 •
edited
Loading

I believe you mean url.mjs.d.ts...?

Yup. Fried brain and running off for dinner.

ghost91-
ghost91- requested changes Aug 15, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ghost91- ghost91- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, just some small comments.

Collection also needs to be updated. It's mostly just documentation changes, but there are some small implementation changes, too (e.g. the index being passed to map callbacks, etc.)

Comment thread src/foundry/common/primitives/array.mjs.d.ts
Comment thread src/foundry/common/primitives/set.mjs.d.ts
Comment thread src/foundry/common/primitives/set.mjs.d.ts
Comment thread src/foundry/common/primitives/set.mjs.d.ts
Comment thread src/foundry/common/primitives/string.mjs.d.ts
Comment thread src/foundry/common/utils/helpers.mjs.d.ts Outdated
Comment thread src/foundry/common/utils/helpers.mjs.d.ts Outdated
Comment thread src/foundry/common/utils/helpers.mjs.d.ts Outdated
Comment thread src/foundry/common/utils/helpers.mjs.d.ts Outdated
Comment thread src/foundry/common/utils/helpers.mjs.d.ts Outdated
@Spice-King
Copy link
Copy Markdown
Contributor Author

Spice-King commented Aug 16, 2022

Collection also needs to be updated.

Whoops. Somehow got missed when I was diffing.

@Spice-King Spice-King force-pushed the v10/common-utils branch 2 times, most recently from 29b879b to 4bc392a Compare August 16, 2022 04:33
@Spice-King Spice-King requested a review from ghost91- August 18, 2022 02:32
@Spice-King
Copy link
Copy Markdown
Contributor Author

Spice-King commented Aug 18, 2022

Right, should be all good for now and updated the only things under common/utils and common/primitives to v10.278

ghost91-
ghost91- requested changes Aug 19, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ghost91- ghost91- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny small comment, aside from this it's perfect! :)

Comment thread src/foundry/common/utils/helpers.mjs.d.ts Outdated
@ghost91- ghost91- merged commit 8dad13e into League-of-Foundry-Developers:main Aug 19, 2022
@Spice-King Spice-King deleted the v10/common-utils branch August 20, 2022 01:32
Spice-King added a commit to Spice-King/foundry-vtt-types that referenced this pull request Aug 20, 2022
@Spice-King
Update head.d.ts to v10.277, depends on League-of-Foundry-Developers#…
cee9150 
…2192 for Color
Spice-King added a commit to Spice-King/foundry-vtt-types that referenced this pull request Aug 20, 2022
@Spice-King
Update head.d.ts to v10.2788888888ds on League-of-Foundry-Developers#…
3849b61 
…2192 for Color
Spice-King added a commit to Spice-King/foundry-vtt-types that referenced this pull request Aug 20, 2022
@Spice-King
Update head.d.ts to v10.278 on League-of-Foundry-Developers#2192 for …
87475ab 
…Color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghost91- ghost91- ghost91- approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@Spice-King @ghost91-