Dockerize the development environment #3
Conversation
Create a docker-compose with an IPFS instance and a Swagger Editor instance with a live reload pointing on the developed swagger.yaml.
docker/browsersync/Dockerfile
Outdated
| @@ -0,0 +1,7 @@ | |||
| FROM alpine:3.4 | |||
There was a problem hiding this comment.
If it's only for node, use a node alpine official image instead.
docker/browsersync/Dockerfile
Outdated
|
|
||
| RUN apk add --update nodejs | ||
|
|
||
| CMD npm install && npm start |
There was a problem hiding this comment.
I don't see a copy of package.json in the Dockerfile, meaning this Dockerfile doesn't work on its own: the CMD would fail as is.
We usually want a Dockerfile to be self-contained, docker-compose is just a convenience wrapper above.
| @@ -0,0 +1,7 @@ | |||
| #!/bin/sh | |||
|
|
|||
| ipfs config Addresses.API /ip4/0.0.0.0/tcp/5001 | |||
There was a problem hiding this comment.
Why did you choose this method over the ipfs config file one?
That's shame we have to modify two bash scripts, whereas using a config file seems to be built-in in the start script shipped with the container.
docker/editor/index.html
Outdated
| @@ -0,0 +1,98 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I think we could ship these files within a docker image and only mount the config as a volume.
dockerize the development environment
Description
Create a docker-compose with an IPFS instance and
a Swagger Editor instance with a live reload
pointing on the developed swagger.yaml.
How Has This Been Tested?
Tested humanly.
Types of changes
Checklist: