Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better trimmer #122

Merged
merged 33 commits into from
Nov 27, 2022
Merged

Better trimmer #122

merged 33 commits into from
Nov 27, 2022

Conversation

LeGoffMael
Copy link
Owner

Controller

  • new isRotated getter
  • renamed getter isTrimmmed typo into isTrimmed

TrimSlider

  • 2 different styles possible bar and circle
  • new onTrimmingColor, onTrimmedColor, borderRadius and edgesSize style params
  • new fade in animation when thumbnails are generating
  • thumbnails are regenerated if after edit changes there is not enough to fill the slider
  • new hasHaptic param
  • video position is updated better on indicator, start trim or end trim changes

CoverSelection

  • Removed indicators options of CoverSelectionStyle() and added selectedCoverBuilder param to custom selected cover widget
  • New wrap param to customize the Wrap widget used to to display the cover thumbnails
  • Renamed height param into size
  • new fade in animation when thumbnails are generating

Mael Le Goff and others added 30 commits November 4, 2022 20:11
[temp] fix cover thumb scale
123b9cd
@LeGoffMael
[fix] cover selection rotation size issue
c04c346
@LeGoffMael
[fix] scale issue in CoverSelection
51ae1bb
@LeGoffMael
[fix] fix issue CoverSelection thumbs are cropped after ratio chang…
65dc9e7 
…ed but not crop value
@LeGoffMael
[clean] remove code duplication
dfd515f
@LeGoffMael
[fix] scale thumbs up to avoid empty spaces in ThumbnailSlider
f47d269
@LeGoffMael
[fix] generate thumbnails after crop to fit the ThumbnailSlider
ac46d31
@LeGoffMael
[fix] thumbnails size wrong after rotation
97de803
[clean] move video thumbnails generation in a single file
97995ca
[typo] fix typo isTrimmmed -> isTrimmed
9d6a141
[change] show appropriate thumbnails in TrimSlider when the generated…
4b057a7 
… thumbs length is > than the max needed to be displayed
[clean] clean TrimSlider widget
acd58ca
[clean] switch TrimTimeline to stateless
dc166ad
[change] improve video cursor update on trim
374c0b7
[new] add fadein animation in the thumbnail generation
ab686ef
@LeGoffMael
[change] new params in CoverSelection
46a6c17 
- new `borderRadius` style param
- new `selectedCoverBuilder` function to buid selected cover indicator
@LeGoffMael
[change] new style in TrimSlider
20f0d4f 
- new edge style bar or circle
- new trimming color
@LeGoffMael
[new] borderRadius style for TrimSlider
dbf041e
@LeGoffMael
[change] change trim slider default style and combine edges and rect …
05f80d2 
…path to avoid colors overlap
@LeGoffMael
[paint] add trimslider inner radius on the edges
fd94528
@LeGoffMael
[clean] use const for entities constructors
4b0aa78
@LeGoffMael
[change] fix trim edges and video position
ff43e3b 
- add margin to set video frame to be more accurate
- since trim slider paint is now outside of the trim rect, need to update spacing
@LeGoffMael
[new] haptic feedback when trimslider touch an edge
a0de7f3
@LeGoffMael
[style] new onTrimmedColor param in TrimSliderStyle
a5325b8
@LeGoffMael
[style] change trim default style colors
99a4f92
@LeGoffMael
[example] improve example
6300360
@LeGoffMael
[style] new wrap parameter in CoverSelection to custom the thumbn…
d140d8c 
…ails wrap widget
@LeGoffMael
[fix] do haptic and set to min/max trim when trimmer has scroll view
b265643
@LeGoffMael
[fix] video indicator position when trimmer has scroll view
fcb6ec7
@LeGoffMael
[fix] be able to trim to the minimum size possible
7654d3a
@LeGoffMael LeGoffMael merged commit fb016af into master Nov 27, 2022
@LeGoffMael LeGoffMael deleted the better-trim branch January 3, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LeGoffMael