Fix getRelativePath behaviour on case-insensitive filesystems
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically when resolving an import in file `A/a.ts` "from" file `B/b.ts` e.g.
import x from "../B/b"
the function will be called as `getRelativePath("A", "b")`. Note the `"b"` path
has been lowercased by tsc at some point and that `"A"` may not exist on disk
at this point as it's being generated.
The previous logic would fail on `realpathSync.native(from)` because `from =
"A"` does not exist on disk yet and would not fix the casing of `to`. As such
`"../b"` would be returned instead of the correct `"../B"`. The simplest fix is
to swap the realpath calls which is what we do here, as typically `to` will
exist (it's what is being imported) and `from` may not.
|
Hey @sammko, sorry for the late reply. Can you please add some unit tests to check for this issue. Other than that LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for explanation. A more elegant solution can likely be devised but this should take care of most cases. Let me know if I should provide more details or a reproducer.