Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env vars + erasing password in-memory #48

Merged
merged 21 commits into from
May 24, 2024
Merged

Fix env vars + erasing password in-memory #48

merged 21 commits into from
May 24, 2024

Conversation

LeChatP
Copy link
Owner

@LeChatP LeChatP commented May 22, 2024

No description provided.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 73.07307% with 269 lines in your changes are missing coverage. Please review.

Project coverage is 66.03%. Comparing base (334c539) to head (b16dbec).
Report is 3 commits behind head on main.

Current head b16dbec differs from pull request most recent head 3439f1a

Please upload reports for the commit 3439f1a to get more accurate results.

Files Patch % Lines
src/chsr/cli/process/json.rs 83.40% 75 Missing ⚠️
src/sr/pam/mod.rs 0.00% 57 Missing ⚠️
src/chsr/cli/usage.rs 38.09% 39 Missing ⚠️
src/sr/pam/rpassword.rs 26.00% 37 Missing ⚠️
src/database/options.rs 63.51% 27 Missing ⚠️
src/chsr/cli/process.rs 80.95% 16 Missing ⚠️
src/sr/pam/cutils.rs 66.66% 9 Missing ⚠️
src/chsr/cli/pair.rs 95.00% 7 Missing ⚠️
src/sr/main.rs 50.00% 1 Missing ⚠️
src/sr/pam/securemem.rs 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   56.10%   66.03%   +9.93%     
==========================================
  Files          18       27       +9     
  Lines        2918     2806     -112     
==========================================
+ Hits         1637     1853     +216     
+ Misses       1281      953     -328     
Flag Coverage Δ
unittests 66.03% <73.07%> (+9.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeChatP LeChatP merged commit 2e6359b into main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant