Repository navigation
Přestavba na upstream T3 Code v0.1.3 - #137
Conversation
agentrozjedemeai
left a comment
There was a problem hiding this comment.
@immakermatty — exact-head review of bd911a3de4ede82878610bd1c952fff653901f18. The patch stack is based on v0.1.3, the old main and stable tag match, git diff --check is clean, and the manually dispatched Lazurio Fork CI run 40652295524 is green on this SHA. Two Buddy conversation regressions still need a fix and regression coverage before the swap:
-
[P2] Day pane can point at an invisible Delegace wake.
apps/server/src/lazurio/buddySurfaceDays.ts:108-111fetches every user-role message and:70-89chooses the first message of each local day without excluding agent-sent wakes. Butapps/web/src/lazurio/actingSender.ts:152-174removes Delegace wakes from the timeline, whileapps/web/src/lazurio/BuddySurface.tsx:559-565jumps to that first message ID.useBuddyDayJumpatBuddySurface.tsx:230-245cannot find it and clears the request when history is exhausted. If a Delegace wake precedes the person's message that day, clicking the day never reaches the visible conversation; a wake-only day becomes a dead entry. Derive days from the same visible-person predicate (and cover wake-first/wake-only cases) rather than selecting allrole=userrecords. -
[P2] A linked thread bypasses Buddy's one-conversation route.
apps/web/src/routes/_chat.tsx:38-43andapps/web/src/components/ThreadRouteView.tsx:139-146render any ready thread route, even while the primary server is in Buddy mode.apps/web/src/components/ChatView.tsx:579then uses unscopeduseBuddySurfaceMode()to apply Buddy's steer/composer behavior to that thread; other Buddy wrappers similarly hide thread details. The mode helper explicitly scopes byenvironmentIdwhen passed one (BuddySurface.tsx:58-67), and the server guard only refuses new threads/forks, not read-only navigation to a pre-existing or secondary-environment thread (buddySurfaceGuards.ts:32-59). Redirect non-Buddy targets to the canonical Buddy thread, or consistently scope all presentation/behavior to the target environment and thread ID; add a direct-URL regression test.
I did not merge, push, dispatch, or touch Ring 0. The local contract test ran 45/46 in this dependency-free temporary clone; the sole failure was module resolution (@t3tools/shared absent because node_modules was not installed), not a source assertion. CI on this exact SHA did complete successfully. The intentional rebuild conflict with main is not a finding. Ring 0 browser/runtime checks remain stage-7 work.
bd911a3 to
6f04174
Compare
|
Thanks. Both findings are fixed on head
Local checks on the new head:
Lazurio Fork CI on the exact head: run 40715377422. Please re-review on |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
@immakermatty — APPROVED on exact head 6f04174a492ee54d760e7942bafa816a672cffca (review round 2). I checked the v0.1.3 patch-stack base and target order, git diff --check, the immutable v0.1.2-lazurio.6 tag against old main, and the changed Buddy day/route logic and regression tests. The day pane now excludes recorded Delegace wakes from day/first-message selection, and a direct primary-Environment thread URL redirects to Buddy while a secondary-Environment thread keeps its own chat behavior. No unresolved review threads were present. In my isolated dependency-free clone the release contract ran 46/47; the sole failure was missing workspace package resolution (@t3tools/shared, no node_modules), not an assertion. The exact-head CI has green server/web compatibility and linux-x64 archive jobs; darwin-arm64 is still queued, so this approval is not a swap/release gate. Complete that job and the remaining runbook/Ring 0 checks before any main swap. I did not merge, push, or dispatch.
Status: ready for review / approved. Pablo APPROVED head
6f04174a49in round 2 (2026-10-28 16:16:53 UTC, after the head commit). The swap waits for the macOS arm64 archive job: it has had no GitHub runner in three attempts; attempt 4 is queued in run 40715377422. Then main swap (stage 6), preview and Ring 0 (stage 7) after the Example canary.Rebuild of the Lazurio overlay onto upstream T3 Code v0.1.3 (
d2c44031). Tracking issue with the decision table: #136.What it is
This branch replaces
mainat the swap (stage 6 of the runbook); it is never merged.main(697648c0) is captured exactly by the immutable stablev0.1.2-lazurio.6.What changes on the new base
X.Y.Zand would never offer0.1.3-lazurio.0→.1. The install scripts use the newreleases/latestlookup.startAppServices().t3_queue,t3_pending_request,t3_thread_transfer). Thet3CLI that agents and Buddy use is unchanged, and a new test fails if the old tool names come back.installChatRouteCommands.navigateTimeline.chatViewPanelPresence.test.tscarry over.lazurio_questionsnow says it overrides Codex's own Default-mode text that asks in plain text.react-effect-budget, and service methods useEffect.fnwhere the new Effect diagnostics require it.bootError.tsandbundledDev.test.ts, because the new "failed to start" screen now shows the overlay's name.chatRouteCommands.ts.Review round 1 fixes (head
6f04174a49)Both defects also existed on the old main. They are fixed here, in the rows that own the files, with tests that fail on the old code.
actingSenderVisibility.ts. It has identical server and web copies, and the contract test keeps them equal./does.What does not change
t3CLI surface.Verification (local, on this head)
pnpm-workspace.yamlandpnpm-lock.yamlequal v0.1.3.127.0.0.1bind;request_user_input;Risks
relay-preview.yml,relay-preview-cleanup.yml,stale-needs-more-info.yml) are disabled right after the swap, per the runbook.🤖 Generated with Claude Code
Note
Rebuild on upstream T3 Code v0.1.3 with fx provider and shared source-control registry
sourceControlClientsregistry; the newsource-control-definitionspackage aggregates the six built-in host definitionsfxprovider package and registers its driver, client, and model defaults; adds the Muse usage reader with theMuse Codelabelinfra/task-cachebuild/deploy package with a remote cache (admission limits of 2 stores / 4 reads, Basic-auth developer identity, D1-backed) plus CI wiring throughsetup-ci-deps_chat.settings.*routes (beta → labs, storage → maintenance, integrations → browser) and adds guest-share flows, an inspector-based thread navigation path on iOS, and native terminal output replay (512 KiB buffer) on mobilet3-highlightsnative module (Android JNI + iOS) and thehighlightsengine on web./client/definition→./shared/definitionon all source-control packages,provider-acpdropsserver/coreRuntimeEvents,shareddrops./githubMarkdownLinksand four other subpaths);ThreadPullRequestWatch,TracingResource, and the terminal module interface gain required/changed fields — check in-tree consumers compile against the new shapesMacroscope summarized 6f04174.


Confidence Score: 5/5
No blocking code issue was established; the inspected changes appear safe to merge.Summary
Rebuilds the Lazurio overlay on upstream
v0.1.3, adapting updates, agent commands, and Buddy’s conversation to the new upstream APIs.Acknowledged by
immakermatty: macOS archive verification awaits an available runner; migration069may slow the first start of a large database; live Codex questions and the listed Ring 0 checks remain deferred to the canary; three new upstream workflows will be disabled after the swap.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR U["Upstream v0.1.3"] --> O["Rebuilt Lazurio overlay"] O --> S["Server"] O --> W["Web client"] S --> A["Advertised release"] A --> B["Sidebar update button"] B --> I["Exact-version install"] W --> C["Buddy conversation"] S --> D["Visible messages by day"] D --> CReviews (1) · Last reviewed commit: "release: Lazurio distribution" · Reviewed by Greptile