Repository navigation
Launchpad: the Marketplace's sentence follows the page's language and catalog when they arrive - #389
Merged
Merged
Conversation
… catalog when they arrive On a workstation, opening /marketplace directly showed the Marketplace's sentence in English on a Czech Launchpad, without the Organization's sentence. ui.ts wrote #marketplace-text only on the route, from the copy and catalog of that moment. A workstation's page has no boot document, so its first route was drawn with the default English copy and no catalog, and neither relabel() nor the catalog's loaded callback drew it again. The sentence is now drawn by one function, on the route as before and again from relabel() and the catalog's loaded callback. A Remote Environment's boot document already carried both, so nothing changes there. Checked in headless Chrome on the Launchpad's preview: directly and after a navigation from the Apps home, local cs and en, and hosted cs. Each shows the sentence in the page's language with "Example Company"; main showed English without it when opened directly. Fixes #388 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agentrozjedemeai
approved these changes
Oct 13, 2026
agentrozjedemeai
left a comment
Collaborator
There was a problem hiding this comment.
@immakermatty Approved on exact head 0c0aa7e (base cc6ad07). The redraw covers route entry, locale resolution, and catalog completion without changing non-Marketplace views. In an isolated clone, git diff --check and bun run check:static passed, and bun test tests/launchpad-*.test.ts passed (188/188). In the isolated Launchpad preview, direct /marketplace and navigation back from the Apps view showed Czech with Example Company; direct local English and hosted Czech also showed the correct localized Organization sentence. Live checks passed, no unresolved threads. Review only; no merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On a workstation, opening
/marketplacedirectly (or reloading there) showed the Marketplace's sentence in English on a Czech Launchpad, and without "Do té doby přibývají moduly v Dashboardu Organizace {name}." It stayed that way until you left the Marketplace and came back (#388, found while checking #366).ui.tswrote#marketplace-textonly in the shell'sonRoute, from thecopyand the catalog of that moment. A workstation's page has no boot document, so its first route was drawn with the default Englishcopyand no catalog.relabel()rewrites only[data-message]elements, and the catalog'sloadedcallback did not redraw the sentence either.What changes
A single
drawMarketplace(route)inui.tsdraws the sentence. It runs:relabel(), when the language is known or changes;loadedcallback, when the Organization's name is known.It does nothing on any other route.
What deliberately does not change
Verification
/marketplacedirectly and after a navigation from the Apps home:main(cc6ad07), local cs, direct: English, without the Organization's sentence, which reproduces Launchpad on a workstation: the Marketplace's sentence opened directly stays in English and without the Organization #388. After a navigation it is Czech.bun run check:static: exit 0.bun test tests/launchpad-*.test.ts: 188 pass, 0 fail.Per root decision 0178 the page script's drawing is checked in a browser. The repository has no DOM harness for
ui.ts.Risks
Low.
drawMarketplacereturns at once outside the Marketplace, and the two new calls sit where the page already redraws after its language and catalog arrive.Fixes #388
🤖 Generated with Claude Code