Skip to content

Launchpad: the Marketplace's sentence follows the page's language and catalog when they arrive - #389

Merged
immakermatty merged 1 commit into
mainfrom
agent/LP-388-marketplace-language
Oct 13, 2026
Merged

immakermatty merged 1 commit into
mainfrom
agent/LP-388-marketplace-language

Conversation

@immakermatty

Copy link
Copy Markdown
Contributor

Why

On a workstation, opening /marketplace directly (or reloading there) showed the Marketplace's sentence in English on a Czech Launchpad, and without "Do té doby přibývají moduly v Dashboardu Organizace {name}." It stayed that way until you left the Marketplace and came back (#388, found while checking #366).

ui.ts wrote #marketplace-text only in the shell's onRoute, from the copy and the catalog of that moment. A workstation's page has no boot document, so its first route was drawn with the default English copy and no catalog. relabel() rewrites only [data-message] elements, and the catalog's loaded callback did not redraw the sentence either.

What changes

A single drawMarketplace(route) in ui.ts draws the sentence. It runs:

  • on the route, as before;
  • from relabel(), when the language is known or changes;
  • from the catalog's loaded callback, when the Organization's name is known.

It does nothing on any other route.

What deliberately does not change

Verification

  • Headless Chrome on the Launchpad's own preview, opening /marketplace directly and after a navigation from the Apps home:
  • bun run check:static: exit 0.
  • bun test tests/launchpad-*.test.ts: 188 pass, 0 fail.

Per root decision 0178 the page script's drawing is checked in a browser. The repository has no DOM harness for ui.ts.

Risks

Low. drawMarketplace returns at once outside the Marketplace, and the two new calls sit where the page already redraws after its language and catalog arrive.

Fixes #388

🤖 Generated with Claude Code

… catalog when they arrive

On a workstation, opening /marketplace directly showed the Marketplace's
sentence in English on a Czech Launchpad, without the Organization's
sentence. ui.ts wrote #marketplace-text only on the route, from the copy
and catalog of that moment. A workstation's page has no boot document, so
its first route was drawn with the default English copy and no catalog,
and neither relabel() nor the catalog's loaded callback drew it again.

The sentence is now drawn by one function, on the route as before and
again from relabel() and the catalog's loaded callback. A Remote
Environment's boot document already carried both, so nothing changes
there.

Checked in headless Chrome on the Launchpad's preview: directly and after
a navigation from the Apps home, local cs and en, and hosted cs. Each
shows the sentence in the page's language with "Example Company"; main
showed English without it when opened directly.

Fixes #388

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@immakermatty Approved on exact head 0c0aa7e (base cc6ad07). The redraw covers route entry, locale resolution, and catalog completion without changing non-Marketplace views. In an isolated clone, git diff --check and bun run check:static passed, and bun test tests/launchpad-*.test.ts passed (188/188). In the isolated Launchpad preview, direct /marketplace and navigation back from the Apps view showed Czech with Example Company; direct local English and hosted Czech also showed the correct localized Organization sentence. Live checks passed, no unresolved threads. Review only; no merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launchpad on a workstation: the Marketplace's sentence opened directly stays in English and without the Organization

2 participants