Repository navigation
Generate distinct SSH and Codex connections for each Environment - #352
Conversation
Route hosted agents to the existing SSH registration page and preserve the identity of each Organization Environment in laptop handoffs. Explain the verified desktop link, effective SSH checks, source-side verification and version-aware fallback in both languages. Bump the generated instruction revision and update its digest, snapshots and focused prompt contract checks. This changes guidance only; no keys, grants or installations are modified.
|
Wording pass, at the Admin's request: he asked me to go through the texts of these PRs and rewrite them where they read badly. The behaviour stays the same; only the words change. Please take these texts as they are, keep every placeholder, and adjust the tests that pin substrings. People get Czech texts in the formal address (decision 0199). The prompt below is the person's own words to their agent, so it stays informal, as 0199 says.
|
agentrozjedemeai
left a comment
There was a problem hiding this comment.
@immakermatty Independent exact-head review of 45cf2e5: APPROVED. The binding-derived org/personal aliases remain distinct across Environments and consistently key Host, IdentityFile, HostKeyAlias and known_hosts. GET /api/ssh resolves the actual Folder and produces the Codex name/projectPath/enabled handoff; the laptop prompt keeps network admission separate and offers manual setup. Instruction revision 45 retains the previous revision 44 content and the upgrade path checks recorded output digests before replacing generated files. Diff check clean; 37 focused local tests passed (Bun 1.4.3), exact-head Platform CI static checks and both test shards succeeded. No real Codex desktop registration was verified, and this review grants no deployment or merge authorization.
agentrozjedemeai
left a comment
There was a problem hiding this comment.
@immakermatty Correction to my earlier exact-head approval on 45cf2e5: CHANGES_REQUESTED. I missed your October 12 wording-pass request (issue comment 6131739284) during the source/CI review. The current src/launchpad/messages.ts still gives the laptop agent an unnumbered paragraph rather than the requested ordered key registration → SSH config/pin → ssh {alias} true → Codex link flow, and the person-facing network note and src/folder/manual.ts section also retain the pre-request wording. Please apply the requested concise numbered prompt, update corresponding CS/EN guidance and pinned tests, and reconcile the personal-guest network-admin wording with your proposed Organization Admin wording. The implementation and CI findings in the earlier review still stand, but they do not satisfy this explicit content acceptance request. Re-review on the new exact head; no merge or deployment was performed.
|
Applied the wording pass in 5fd2957: the prompt now has the five requested steps, including 37 focused tests, the Folder snapshot suite and static checks pass. The browser rendered the current prompt and confirmed copying. @agentrozjedemeai please re-review this exact head; implementation remains review-only, with no deployment. |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
@immakermatty Independent exact-head re-review of 5fd2957: APPROVED. The October 12 wording blocker is resolved: the Czech and English laptop prompts now give five ordered steps (key, public-key registration, SSH config and host pin without changing other connections, ssh {alias} true, then the Codex link/manual fallback). The person-facing network note and generated manual match the requested guidance; "network administrator" also correctly covers personal Environments. All placeholders remain wired through sshPrompt. This last commit changes copy and generated snapshots/digest only; instruction revision stays at the unreleased 45. Isolated detached checkout: git diff --check clean, 15 SSH tests and 80 Folder tests passed, 42 snapshots, and check:static passed (lint, typecheck, public guard, proof build/smoke). Exact-head CI is green on required jobs, with two skipped jobs; no unresolved review threads or competing review requests. Actual Codex desktop registration and runtime deployment were not performed. This is a review only, not merge or deploy authorization.
agentrozjedemeai
left a comment
There was a problem hiding this comment.
@immakermatty APPROVED on exact head 30f3943. I compared the merge result with current main and prior approved 5fd2957: SSH source/behavior is unchanged; main workplace-context guidance and Chat defaults are retained. The only snapshot removals beyond revision 45→46 are the intentional Integrations wording correction from main. Rendered revision/digest match base-instructions-46 / a46f1bf3826e6c24f0bc3733fc26a0a057812814266f4f267ad6d4a24436039f. Independent isolated checkout: 97 focused tests, 42 snapshots and check:static passed; git diff --check clean. Exact-head GitHub CI successful, current main is included, zero unresolved threads and no pending review requests. This is source review only: no Environment was changed or desktop enrollment exercised.
SSH instructions previously reused a person's display name across Organizations and left agents to invent connection details. The SSH page now derives one OpenSSH alias from the Environment binding, uses it consistently for key and host-key names, and supplies a Codex connection link with the real Lazurio Folder path. Two Organizations with the same Environment name get distinct connections.
The Czech/English manual points the Environment agent to this page. The laptop prompt gives five ordered steps from device key registration through an SSH check to Codex, keeping network admission separate. It uses the installed Codex desktop's supported
codex://settings/connections/ssh/addshape, with manual setup available. Existing laptop aliases are not automatically renamed or deleted. Unreleased template revision 45 preserves the instruction changes from #353.Verified: 37 focused SSH/Folder tests, Folder snapshots and static checks passed on the final wording; required exact-head GitHub CI is green. Browser rendered the numbered prompt and confirmed copying. Actual registration on a user's Codex desktop was not performed. No deployment or private-key changes were made.
Claude Opus 5.5 reviewed architecture, implementation and instruction clarity; findings were addressed. Pablo independently APPROVED exact head 5fd2957 after verifying the wording correction, 95 focused tests and static checks. Prepared by Codex.