Repository navigation
Offline guide: address the person formally (vykání); F41 describes the redesign - #331
Merged
Merged
Conversation
…e redesign The page's Czech copy follows the brand rule of 2026-10-11 that the rest of the Launchpad, the shell and the CLI follow (#328): "Zapněte Tailscale a vyberte síť", "Otevřete Tailscale…", "Na ikonu Tailscale klikněte pravým tlačítkem. Nevidíte ji?…", "…nebo se vraťte do Dashboardu", the cursor's tag "Vy" and "Váš účet" in the sketch. English is unchanged. docs/decisions.md gets the F41 addendum of 2026-10-12 for #327's page: one command under a moving sketch of the detected system, no system switch, numbered steps or retry button, the way back as a link beside the rail's logo (Pablo's follow-up on #327). The tests and the browser smoke check the new words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agentrozjedemeai
approved these changes
Oct 12, 2026
agentrozjedemeai
left a comment
Collaborator
There was a problem hiding this comment.
@immakermatty Steward QA on exact head 8eebf6c: approved. The Czech offline-page copy consistently uses formal address; English is unchanged. F41 addendum accurately supersedes the old switch/steps/retry-button and Dashboard button without changing the worker contract. Assertions remain scoped to the new wording. In an isolated detached checkout: 13 focused tests passed, check:static passed, git diff --check clean. Exact-head GitHub checks passed, with no unresolved threads. The requester reports 15/15 browser smoke checks; I did not rerun that browser smoke locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: ready for review.
Why
docs/decisions.mdF41 still described the numbered steps, the system switch and the retry button.The Organization Admin asked on 2026-10-12 to ship the redesign to every Environment, so both land before the next release candidate.
What changes
src/shell/offline-page.ts, Czech only:English is unchanged.
tests/shell-offline-guide.test.ts,tests/launchpad-offline-guide.test.ts,scripts/smoke-offline-guide.ts: the same assertions, now on the new words. Nothing is removed or loosened.docs/decisions.md: the F41 addendum of 2026-10-12 describes the page as Offline guide: one command under a moving sketch of the person's own system (DEV-6651) #327 built it:It marks what it supersedes. The worker contract is unchanged.
Verification
bun test tests/shell-offline-guide.test.ts tests/launchpad-offline-guide.test.ts: 13 pass.bun run check:staticpasses.scripts/smoke-offline-guide.ts, with Chromium through Playwright supplied externally: all 15 checks pass, including the guide shown on a failed navigation with the new heading.Plan: DEV-6651 (HumanAndMachine-ai Mission Control).
🤖 Generated with Claude Code