Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create witness and blob preloader #31

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

bxue-l2
Copy link
Collaborator

@bxue-l2 bxue-l2 commented Feb 18, 2025

This PR overwrites #24 and #28 .

This PR introduces two new objects

  • EigenDABlobWitnessData : This is a holder for eigenda blobs, kzg proof, dacert and validity proof. The dacert contains aggregate signature to be checked against validity proof. The dacert contains kzg commitment for kzg proof and eigenda blob. EigenDABlobWitnessData is produced as an artifact from running the hokulea derivation procedure
  • PreloadedEigenDABlobProvider : This implements EigenDABlobProvider, and ability to import from EigenDABlobWitnessData.

Later PRs:

  1. Implement EigenDABlobProvider for PreloadedEigenDABlobProvider
  2. Implement validity validation logics.

@bxue-l2 bxue-l2 marked this pull request as ready for review February 18, 2025 22:34
@bxue-l2 bxue-l2 requested a review from samlaf February 19, 2025 22:02
@@ -0,0 +1,5 @@
# `compute-kzg-proof`

This is the temporary crate for generating a kzg proof using eigenda blob. In the future, such proof is carried inside the blob header. Then this crate can be removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym by "inside the blob header"?
Also is there anything preventing this other implementation right now? Or is it just that its harder and you didn't want to do it now?

Copy link
Collaborator Author

@bxue-l2 bxue-l2 Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @litt3 is working on it in proxy

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bxue-l2 Are you referring to the addition of pi to the BlobCommitment?

That's on my list of TODOs, but not at the top, FYI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think it is urgent

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue tracking that? best to link to that issue than to leave vague comments. Then people know exactly what's up and how to track the progress.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue, but I suppose the question is whether it's appropriate to link private linear issues in a public forum. Seems a bit odd

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, which is why we should always be creating issues on github first, and linear will import them. Isn't this the issue? Layr-Labs/eigenda#1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants