-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route createAVSPaymetnSubmission via SM #92
base: master
Are you sure you want to change the base?
Conversation
there is some more updates that I think we need to make this more flexible. we need to add a function with an initializer modifier on the service manager to initialize the owner and rewards updater state variables. this makes it so you don't need to prank(address(0)); these values need to be read from a config file for the hello world deployment And then we need to improve the core deployment library to set the rewards updater address on the RewardsCoordinator. We can't read this from the config json files in the core contract repo. It looks like it's an address controlled by the person who wrote the script or maybe the pk for it is shared, but it's likely an internal address to eigenlayer and needs to be more configurable or a default anvil key |
To make it more straightforward, should we just hardcode it in the CoreDeploymentLib.sol file to a default anvil key ourselves instead of using the config? |
* fix: initialize sm and rewards coordinator config * add rewards owner and initiator as inputs to deploy * added helloWorld config --------- Co-authored-by: kachapah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you add a step in the README that runs through after the contracts are deployed is able to go through the payment flow. I realize we missed that on the first pass for this feature
Routes createAVSRewardsSubmission call via the servicemanager called by the rewardsInitiator vs directly calling it.