feat: multichain interfaces #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
May 8, 2025
gpsanant
reviewed
May 8, 2025
| /// @notice A contract that calculates the weights for all operators in a given operatorSet | ||
| /// @notice This is a base interface to send operator weights to the `IOperatorTableCalculator` | ||
| /// @notice We separate this out to be able to plug-in different operator weight calculators for each operatorSet | ||
| interface IOperatorWeightCalculator { |
Collaborator
Author
There was a problem hiding this comment.
Separate external calculator contract per operatorSet. The TableCalculator is global for all operatorSets. The IOperatorWeightCalculator is for a single operatorSet
Contributor
There was a problem hiding this comment.
So many contracts :( can we just put it all in this thing?
Collaborator
Author
There was a problem hiding this comment.
yes we can, but leaving decoupled for now
Contributor
There was a problem hiding this comment.
seems like we want abstract contracts rather than interfaces? maybe im being pedantic
Collaborator
Author
There was a problem hiding this comment.
Yeah, the current impl has abstract contracts. We definitely can implement it that way
gpsanant
reviewed
May 8, 2025
gpsanant
reviewed
May 8, 2025
gpsanant
reviewed
May 8, 2025
gpsanant
approved these changes
May 9, 2025
0xrajath
reviewed
May 12, 2025
Comment on lines
+52
to
+53
| /// @notice the address of the entity that can eject operators | ||
| function ejector() external returns (address); |
Contributor
There was a problem hiding this comment.
Curious why the Ejector is in this contract vs something like the AVSRegistrar?
Collaborator
Author
There was a problem hiding this comment.
You need to eject on L2s, and the AVSRegistrar isn't there
ypatil12
added a commit
that referenced
this pull request
Jul 10, 2025
**Motivation:**
Initial interfaces for multi chain.
**Modifications:**
***TableCalculator***
The separation here is designed to decouple
- Curve-Specific Calculation
- Generic Table Calculation Getters (applicable for all curve types)
- Weighting. `IOperatorWeightCalculator` is a calculation contract that
defines how to weigh stakes of an operatorSet. This contract may or may
not be stateless. In practice, this can be an external contract or
library.
```mermaid
classDiagram
IOperatorWeightCalculator <-- IOperatorTableCalculator : uses many
IOperatorTableCalculator <|-- IECDSATableCalculator : implements
IOperatorTableCalculator <|-- IBN254TableCalculator : implements
class IOperatorWeightCalculator {
+getOperatorWeights(OperatorSet)
}
class IOperatorTableCalculator {
+setOperatorWeightCalculator(OperatorSet, IOperatorWeightCalculator)
+calculateOperatorTableBytes(OperatorSet) returns (bytes)
+getOperatorWeightCalculator(OperatorSet) returns (IOperatorWeightCalculator)
}
class IECDSATableCalculator {
+calculateOperatorTable(OperatorSet) returns (ECDSAOperatorInfo[])
}
class IBN254TableCalculator {
+calculateOperatorTable(OperatorSet) returns (BN254OperatorSetInfo)
+getOperatorInfos(OperatorSet) returns (BN254OperatorInfo[])
}
```
***CertificateVerifier***
The `CertificateVerifier` decouples setting of the table and
verification. See below:
```mermaid
classDiagram
ICertificateVerifier <|-- IBN254CertificateVerifier: implements
IBN254TableManager <|-- IBN254CertificateVerifier: implements
class ICertificateVerifier {
<<interface>>
+setOperatorTableUpdater(address)
+setEjector(address)
+setMaxOperatorTableStaleness(uint32)
+operatorSet() returns (OperatorSet)
+operatorTableUpdater() returns (address)
+ejector() returns (address)
+maxOperatorTableStaleness() returns (uint32)
+latestReferenceTimestamp() returns (uint32)
}
class IBN254TableManager {
<<interface>>
+updateOperatorTable(OperatorSet, uint32, BN254OperatorSetInfo)
+ejectOperators(OperatorSet, uint32, uint32[], BN254OperatorInfoWitness[])
}
class IBN254CertificateVerifier {
<<interface>>
+verifyCertificate(BN254Certificate) returns (uint96[])
+verifyCertificateProportion(BN254Certificate, uint16[]) returns (bool)
+verifyCertificateNominal(BN254Certificate, uint96[]) returns (bool)
}
```
***Migration Story***
We want a migration path to store all tables in a singleton core
contract. In order to do so, we future-proofed the _transportation_
interface to pass in an `operatorSet` when updating an operatorTable.
Permissions setting can be done by an EOA, so we don't need to make that
forwards compatible. If all the tables live in a single contract, then
for Bn254 caching, the verification must cache stakes in the singleton.
**Result:**
Initial Interfaces. I see these changing for the following reasons:
- Encoding leafs with a salt
- Table generation-based trusted operator table updates
- Multiquorum sig support (but EigenDA can build their own)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Initial interfaces for multi chain.
Modifications:
TableCalculator
The separation here is designed to decouple
IOperatorWeightCalculatoris a calculation contract that defines how to weigh stakes of an operatorSet. This contract may or may not be stateless. In practice, this can be an external contract or library.classDiagram IOperatorWeightCalculator <-- IOperatorTableCalculator : uses many IOperatorTableCalculator <|-- IECDSATableCalculator : implements IOperatorTableCalculator <|-- IBN254TableCalculator : implements class IOperatorWeightCalculator { +getOperatorWeights(OperatorSet) } class IOperatorTableCalculator { +setOperatorWeightCalculator(OperatorSet, IOperatorWeightCalculator) +calculateOperatorTableBytes(OperatorSet) returns (bytes) +getOperatorWeightCalculator(OperatorSet) returns (IOperatorWeightCalculator) } class IECDSATableCalculator { +calculateOperatorTable(OperatorSet) returns (ECDSAOperatorInfo[]) } class IBN254TableCalculator { +calculateOperatorTable(OperatorSet) returns (BN254OperatorSetInfo) +getOperatorInfos(OperatorSet) returns (BN254OperatorInfo[]) }CertificateVerifier
The
CertificateVerifierdecouples setting of the table and verification. See below:classDiagram ICertificateVerifier <|-- IBN254CertificateVerifier: implements IBN254TableManager <|-- IBN254CertificateVerifier: implements class ICertificateVerifier { <<interface>> +setOperatorTableUpdater(address) +setEjector(address) +setMaxOperatorTableStaleness(uint32) +operatorSet() returns (OperatorSet) +operatorTableUpdater() returns (address) +ejector() returns (address) +maxOperatorTableStaleness() returns (uint32) +latestReferenceTimestamp() returns (uint32) } class IBN254TableManager { <<interface>> +updateOperatorTable(OperatorSet, uint32, BN254OperatorSetInfo) +ejectOperators(OperatorSet, uint32, uint32[], BN254OperatorInfoWitness[]) } class IBN254CertificateVerifier { <<interface>> +verifyCertificate(BN254Certificate) returns (uint96[]) +verifyCertificateProportion(BN254Certificate, uint16[]) returns (bool) +verifyCertificateNominal(BN254Certificate, uint96[]) returns (bool) }Migration Story
We want a migration path to store all tables in a singleton core contract. In order to do so, we future-proofed the transportation interface to pass in an
operatorSetwhen updating an operatorTable. Permissions setting can be done by an EOA, so we don't need to make that forwards compatible. If all the tables live in a single contract, then for Bn254 caching, the verification must cache stakes in the singleton.Result:
Initial Interfaces. I see these changing for the following reasons: