Skip to content

fix: dealloc delay inquality on quorum creation #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

fix: dealloc delay inquality on quorum creation #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/SlashingRegistryCoordinator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,8 @@ contract SlashingRegistryCoordinator is
} else if (stakeType == IStakeRegistryTypes.StakeType.TOTAL_SLASHABLE) {
// For slashable stake quorums, ensure lookAheadPeriod is less than DEALLOCATION_DELAY
require(
AllocationManager(address(allocationManager)).DEALLOCATION_DELAY() > lookAheadPeriod,
lookAheadPeriod
<= AllocationManager(address(allocationManager)).DEALLOCATION_DELAY(),
LookAheadPeriodTooLong()
);
stakeRegistry.initializeSlashableStakeQuorum(
Expand Down
2 changes: 1 addition & 1 deletion test/unit/SlashingRegistryCoordinatorUnit.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ contract SlashingRegistryCoordinator_CreateSlashableStakeQuorum is
uint32 deallocationDelay =
AllocationManager(address(coreDeployment.allocationManager)).DEALLOCATION_DELAY();

uint32 tooLongLookAheadPeriod = deallocationDelay;
uint32 tooLongLookAheadPeriod = deallocationDelay + 1;

vm.prank(proxyAdminOwner);
vm.expectRevert(LookAheadPeriodTooLong.selector);
Expand Down