-
Notifications
You must be signed in to change notification settings - Fork 114
Feat: generate parameters for checkSignatures by referencing OperatorStateRetriever on-chain
#455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI's failing due to formatting: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/14387747950/job/40347432364?pr=455 |
|
There is invalid rpc url error in the CI which I can also see happens on latest commit of dev: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/14312178100/job/40109659601#step:5:883 However this PR has 2 failing CI checks and the latest commit in dev only has 1, so I'm not sure if these are just simply different workflows or am I missing something |
|
The CI errors in this PR are due to external contributors not having access to repository secrets. I'm not sure about the failure in the latest |
ypatil12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, minor comment
ypatil12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the OperatorStateRetriever is already in audit, let's inherit from that and create an unaudited version with this code
refactor: import path refactor: rename format: forge fmt
|
Closing because of #461 |
Motivation:
Computation of the parameters needed for signature verification is typically done through the Eigen go or rust services. However, the rust services are not reliable at the current moment and some projects might want to have signature verifications without having to rely on these services.
This PR aims to make the computation of the
NonSignerStakesAndSignatureparameter easier and accessible through implementing it inOperatorStateRetrievercontractModifications:
getNonSignerStakesAndSignaturetoOperatorStateRetrieverResult:
Computing the data necessary for performing signature verification is more accessible