Skip to content

Conversation

@rubydusa
Copy link
Contributor

@rubydusa rubydusa commented Apr 6, 2025

Motivation:

Computation of the parameters needed for signature verification is typically done through the Eigen go or rust services. However, the rust services are not reliable at the current moment and some projects might want to have signature verifications without having to rely on these services.

This PR aims to make the computation of the NonSignerStakesAndSignature parameter easier and accessible through implementing it in OperatorStateRetriever contract

Modifications:

  • added getNonSignerStakesAndSignature to OperatorStateRetriever
  • added BN256G2 solidity library dependency

Result:

Computing the data necessary for performing signature verification is more accessible

@MegaRedHand
Copy link
Contributor

CI's failing due to formatting: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/14387747950/job/40347432364?pr=455

@rubydusa
Copy link
Contributor Author

There is invalid rpc url error in the CI which I can also see happens on latest commit of dev: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/14312178100/job/40109659601#step:5:883

However this PR has 2 failing CI checks and the latest commit in dev only has 1, so I'm not sure if these are just simply different workflows or am I missing something

@MegaRedHand
Copy link
Contributor

The CI errors in this PR are due to external contributors not having access to repository secrets. I'm not sure about the failure in the latest dev commit, but it seems to be due to something similar. You can run the tests locally with:

HOLESKY_RPC_URL=<some-public-rpc> forge test -vvv
FOUNDRY_PROFILE=forktest forge test --match-contract Integration -vvv

Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, minor comment

Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the OperatorStateRetriever is already in audit, let's inherit from that and create an unaudited version with this code

@ypatil12 ypatil12 dismissed their stale review April 30, 2025 16:16

self-dismissal

@rubydusa
Copy link
Contributor Author

rubydusa commented May 2, 2025

Closing because of #461

@rubydusa rubydusa closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants