Skip to content

perf: code size improvement for registry coordinator #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2025
Merged

perf: code size improvement for registry coordinator #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a57e28
perf: bytecode optimization wip
stevennevins Mar 24, 2025
31ca783
perf: code size improvement with external vis library
stevennevins Mar 24, 2025
89b7317
chore: update foundry.toml to more standard 200 optimizer runs
stevennevins Mar 24, 2025
7d7f3b0
Merge branch 'dev' into perf/rc-codesize-improvement
stevennevins Mar 31, 2025
4ceae12
Merge branch 'dev' into perf/rc-codesize-improvement
stevennevins Apr 1, 2025
0db80b5
Merge branch 'dev' into perf/rc-codesize-improvement
stevennevins Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
# The number of runs specifies roughly how often each opcode of the deployed code will be executed
# across the life-time of the contract. This means it is a trade-off parameter between code size (deploy cost)
# and code execution cost (cost after deployment).
optimizer_runs = 100
optimizer_runs = 200

# Test Configuration

Expand Down
8 changes: 4 additions & 4 deletions src/libraries/QuorumBitmapHistoryLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ library QuorumBitmapHistoryLib {
function currentOperatorBitmap(
mapping(bytes32 => ISlashingRegistryCoordinator.QuorumBitmapUpdate[]) storage self,
bytes32 operatorId
) internal view returns (uint192) {
) external view returns (uint192) {
uint256 historyLength = self[operatorId].length;
if (historyLength == 0) {
return 0;
Expand All @@ -68,7 +68,7 @@ library QuorumBitmapHistoryLib {
mapping(bytes32 => ISlashingRegistryCoordinator.QuorumBitmapUpdate[]) storage self,
uint32 blockNumber,
bytes32[] memory operatorIds
) internal view returns (uint32[] memory) {
) external view returns (uint32[] memory) {
uint32[] memory indices = new uint32[](operatorIds.length);
for (uint256 i = 0; i < operatorIds.length; i++) {
indices[i] = getQuorumBitmapIndexAtBlockNumber(self, blockNumber, operatorIds[i]);
Expand All @@ -87,7 +87,7 @@ library QuorumBitmapHistoryLib {
bytes32 operatorId,
uint32 blockNumber,
uint256 index
) internal view returns (uint192) {
) external view returns (uint192) {
ISlashingRegistryCoordinator.QuorumBitmapUpdate memory quorumBitmapUpdate =
self[operatorId][index];

Expand Down Expand Up @@ -116,7 +116,7 @@ library QuorumBitmapHistoryLib {
mapping(bytes32 => ISlashingRegistryCoordinator.QuorumBitmapUpdate[]) storage self,
bytes32 operatorId,
uint192 newBitmap
) internal {
) external {
uint256 historyLength = self[operatorId].length;

if (historyLength == 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/SignatureCheckerLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ library SignatureCheckerLib {
address signer,
bytes32 digestHash,
bytes memory signature
) internal view {
) external view {
if (!SignatureCheckerUpgradeable.isValidSignatureNow(signer, digestHash, signature)) {
revert InvalidSignature();
}
Expand Down