fix: resolve inheritance order and storage layout for upgraded rc #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnewnami
approved these changes
Mar 18, 2025
8sunyuan
reviewed
Mar 18, 2025
8sunyuan
reviewed
Mar 18, 2025
8sunyuan
reviewed
Mar 18, 2025
8sunyuan
reviewed
Mar 18, 2025
8sunyuan
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
EIP712 in 4.7.0 did not have any storage. In 4.9.0 it has 2 slots of storage which would have caused a storage layout shift based on it's location in the inheritance graph for RegistryCoordinators going through an upgrade
Modifications:
Reorder inheritance, switch to the upgradeable version, and fix build issues that arose from the updates by adding the constructor params to a struct
Result:
Fixed the storage layout issue that would have arisen