Skip to content

test: fix flaky fuzz tests hitting the default operator #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024
Merged

test: fix flaky fuzz tests hitting the default operator #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58aaf16
test: fix flaky fuzz tests hitting the default operator who is alread…
stevennevins May 8, 2024
cabcd03
Merge branch 'dev' into test/fix-flaky-tests
stevennevins May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions test/unit/BLSApkRegistryUnit.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ contract BLSApkRegistryUnitTests_registerBLSPublicKey is

function testFuzz_registerOperator_Revert_WhenZeroPubkeyHash(
address operator
) public {
) public filterFuzzedAddressInputs(operator) {
pubkeyRegistrationParams.pubkeyG1.X = 0;
pubkeyRegistrationParams.pubkeyG1.Y = 0;
BN254.G1Point memory messageHash = registryCoordinator
Expand All @@ -365,7 +365,7 @@ contract BLSApkRegistryUnitTests_registerBLSPublicKey is

function testFuzz_registerOperator_Revert_WhenOperatorAlreadyRegistered(
address operator
) public {
) public filterFuzzedAddressInputs(operator) {
pubkeyRegistrationParams.pubkeyRegistrationSignature = _signMessage(
operator
);
Expand All @@ -392,7 +392,11 @@ contract BLSApkRegistryUnitTests_registerBLSPublicKey is
function testFuzz_registerOperator_Revert_WhenPubkeyAlreadyRegistered(
address operator,
address operator2
) public {
)
public
filterFuzzedAddressInputs(operator)
filterFuzzedAddressInputs(operator2)
{
cheats.assume(operator != address(0));
cheats.assume(operator != operator2);
BN254.G1Point memory messageHash = registryCoordinator
Expand Down Expand Up @@ -425,7 +429,11 @@ contract BLSApkRegistryUnitTests_registerBLSPublicKey is
function testFuzz_registerOperator_Revert_WhenInvalidSignature(
address operator,
address invalidOperator
) public {
)
public
filterFuzzedAddressInputs(operator)
filterFuzzedAddressInputs(invalidOperator)
{
cheats.assume(invalidOperator != operator);
BN254.G1Point memory messageHash = registryCoordinator
.pubkeyRegistrationMessageHash(operator);
Expand Down