Skip to content

Conversation

stevennevins
Copy link
Contributor

No description provided.

@stevennevins
Copy link
Contributor Author

84b5a5d this is removed by alex here and on my branch on core, but master still has it so adding back temporarily

@stevennevins
Copy link
Contributor Author

When we remove the pushing of updateStakes from the DelegationManager, these interfaces can migrate to this repo.

We can create shims for now, so we don't have to worry about type conflicts.

@ChaoticWalrus
Copy link
Contributor

When we remove the pushing of updateStakes from the DelegationManager, these interfaces can migrate to this repo.

We can create shims for now, so we don't have to worry about type conflicts.

So am I understanding right that this is kind of a middleground solution where we leave some interface files in the core repo for the moment and will migrate them later?
Seems OK / it's still an improvement, at least. Will be a bit of a headache if/when we want to change these interfaces though!

@stevennevins
Copy link
Contributor Author

When we remove the pushing of updateStakes from the DelegationManager, these interfaces can migrate to this repo.
We can create shims for now, so we don't have to worry about type conflicts.

So am I understanding right that this is kind of a middleground solution where we leave some interface files in the core repo for the moment and will migrate them later? Seems OK / it's still an improvement, at least. Will be a bit of a headache if/when we want to change these interfaces though!

Yeah, we will definitely need to be mindful of this

Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a step in the right direction; see discussion.

@stevennevins stevennevins merged commit 1f4e93f into master Oct 20, 2023
@stevennevins stevennevins deleted the chore/shim-interfaces-from-core branch October 20, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants