feat: massive improvement in gas usage of `BitmapUtils.bitmapToBytesA… #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray` This function was naively using the built-in `bytes.concat` method, but it copies the array to memory, incurring memory expansion costs! Fuzzed tests (e.g. testFuzz_BytesArrayToBitmapToBytesArray) -- which do the encoding twice -- show a ~20k gas improvement with this commit see for reference: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/7574740337/job/20629810269#step:5:151-152
|
Seems I don't have my pre-commit hooks set up locally correctly for this repo, as I failed the commitlint CI 😅 |
…ToBytesArray` function
|
I added a few simple tests to get better gas estimates (comparing previous usage -> usage with this commit) |
bobwzy
pushed a commit
to bobwzy/eigenlayer-middleware-fork
that referenced
this pull request
Apr 3, 2024
Layr-Labs#149) * feat: massive improvement in gas usage of `BitmapUtils.bitmapToBytesArray` This function was naively using the built-in `bytes.concat` method, but it copies the array to memory, incurring memory expansion costs! Fuzzed tests (e.g. testFuzz_BytesArrayToBitmapToBytesArray) -- which do the encoding twice -- show a ~20k gas improvement with this commit see for reference: https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/7574740337/job/20629810269#step:5:151-152 * chore: add some additional testing which logs the cost of the `bitmapToBytesArray` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rray`
This function was naively using the built-in
bytes.concatmethod, but it copies the array to memory, incurring memory expansion costs!Fuzzed tests (e.g. testFuzz_BytesArrayToBitmapToBytesArray) -- which do the encoding twice -- show a ~20k gas improvement with this commit
see for reference:
https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/7574740337/job/20629810269#step:5:151-152