Skip to content

fix: failing certora-ci #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2024
Merged

fix: failing certora-ci #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a3166a
fix: try installing solc-select
8sunyuan Jan 30, 2024
77bb68a
Merge branch 'm2-mainnet-fixes' into fix-certora-ci
8sunyuan Feb 6, 2024
a9b958f
fix: addShares selector
8sunyuan Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/certora-prover.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,8 @@ jobs:
run: pip install certora-cli
- name: Install solc
run: |
wget https://github.com/ethereum/solidity/releases/download/v0.8.12/solc-static-linux
sudo mv solc-static-linux /usr/local/bin/solc
chmod +x /usr/local/bin/solc
pip install solc-select
solc-select use 0.8.12 --always-install
- name: Verify rule ${{ matrix.params }}
run: |
bash ${{ matrix.params }}
Expand Down
6 changes: 3 additions & 3 deletions certora/specs/core/StrategyManager.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ methods {
// external calls to StrategyManager
function _.getDeposits(address) external => DISPATCHER(true);
function _.slasher() external => DISPATCHER(true);
function _.addShares(address,address,uint256) external => DISPATCHER(true);
function _.addShares(address,address,address,uint256) external => DISPATCHER(true);
function _.removeShares(address,address,uint256) external => DISPATCHER(true);
function _.withdrawSharesAsTokens(address, address, uint256, address) external => DISPATCHER(true);

Expand Down Expand Up @@ -97,7 +97,7 @@ definition methodCanIncreaseShares(method f) returns bool =
f.selector == sig:depositIntoStrategy(address,address,uint256).selector
|| f.selector == sig:depositIntoStrategyWithSignature(address,address,uint256,address,uint256,bytes).selector
|| f.selector == sig:withdrawSharesAsTokens(address,address,uint256,address).selector
|| f.selector == sig:addShares(address,address,uint256).selector;
|| f.selector == sig:addShares(address,address,address,uint256).selector;

/**
* a staker's amount of shares in a strategy (i.e. `stakerStrategyShares[staker][strategy]`) should only decrease when
Expand Down Expand Up @@ -129,7 +129,7 @@ rule newSharesIncreaseTotalShares(address strategy) {
uint256 stakerStrategySharesBefore = get_stakerStrategyShares(e.msg.sender, strategy);
uint256 totalSharesBefore = totalShares(strategy);
if (
f.selector == sig:addShares(address, address, uint256).selector
f.selector == sig:addShares(address, address, address, uint256).selector
|| f.selector == sig:removeShares(address, address, uint256).selector
) {
uint256 totalSharesAfter = totalShares(strategy);
Expand Down