Merged
Conversation
fixes issue that occurs when underlyingToken rounds down amounts, so transferAmountIn = (transferAmountOut - 1), rather than TransferAmountIn = TransferAmountOut. Fee-on-transfer tokens still not supported (these will need their own Strategy)
…racts into fix-first-deposit-rounding
cursed token transfers in 1 wei less than the amount transferred out. test `testDepositTokenWithOneWeiFeeOnTransfer` passes with the changes to StrategyBase in the previous commit (7c8ba7f) but fails without them. Still need to add more complex tests for better coverage on this.
…sfer tokens Also add instructions for preparing the environment to run forked tests. NOTE: the new `FeeOnTransfer_StrategyBase` contract has not been extensively tested yet. This is also captured in a top-level TODO
Contributor
Author
|
CI failures are unrelated to changes; will sort these out after merging. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.