Skip to content

DeDupe EigenPod and Withdrawals Tests #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

DeDupe EigenPod and Withdrawals Tests #267

merged 1 commit into from
Oct 20, 2023

Conversation

ypatil12
Copy link
Collaborator

@ypatil12 ypatil12 commented Oct 19, 2023 •
edited
Loading

  • EigenPod: Combined unit test file into integration test file, as unit tests were not using mocks anyways
  • Withdrawals: Removed inheritance from DelegationTest. Ported over helper functions to withdrawals

No more duped tests!

@ypatil12 ypatil12 linked an issue Oct 19, 2023 that may be closed by this pull request
Testing: test files inherit from other test files, causing multiple tests to run twice #244
Closed
@ypatil12 ypatil12 requested a review from wadealexc October 19, 2023 18:08
ChaoticWalrus
ChaoticWalrus reviewed Oct 20, 2023
View reviewed changes
src/test/Withdrawals.t.sol
Comment on lines +23 to +24
StakeRegistryHarness public stakeRegistry;
StakeRegistryHarness public stakeRegistryImplementation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging the use of this as a potential merge conflict with the branch that removes all middleware contracts -- see #260 or more specifically

eigenlayer-contracts/src/test/EigenLayerTestHelper.t.sol

Lines 7 to 9 in 209e6c8

contract StakeRegistryStub {
function updateStakes(address[] memory) external {}
}

@stevennevins tagging you here for visibility
My thought is that this is probably OK to merge rn, we'll just have to iron out the issue afterwards.

ChaoticWalrus
ChaoticWalrus approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, don't know how I hadn't realized that the EigenPod "unit" tests inherited from the other file.
Just had the one note about merge conflicts, but I think this should still be fine to merge at the moment.

@ypatil12 ypatil12 merged commit 9a4f4a0 into master Oct 20, 2023
@ypatil12 ypatil12 deleted the fix/dedupeTests branch October 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadealexc wadealexc Awaiting requested review from wadealexc

1 more reviewer

@ChaoticWalrus ChaoticWalrus ChaoticWalrus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing: test files inherit from other test files, causing multiple tests to run twice
2 participants
@ypatil12 @ChaoticWalrus