Merged
Conversation
elhajin
reviewed
Jan 30, 2026
elhajin
reviewed
Jan 30, 2026
Contributor
|
@claude check the fixes and make sure that no new bugs are introduced |
elhajin
approved these changes
Feb 5, 2026
eigenmikem
added a commit
that referenced
this pull request
Feb 13, 2026
**Motivation:** Address findings from the Certora security audit of the Duration Vaults implementation. **Modifications:** ### Medium Severity - **M-01 Fix**: Added `setRewardsClaimer(address claimer)` to designate a claimer for operator-attributed rewards, ensuring if any rewards accrued during split activation delay or via a new rewards type can be claimed - **M-02 Fix**: Implemented retry mechanism in `markMatured()` and `advanceToWithdrawals()` - both now check if vault is in WITHDRAWALS state and re-attempt operator cleanup (`_deallocateAll()` and `_deregisterFromOperatorSet()`) if needed - **M-03 Fix**: Added `updateDelegationApprover(address newDelegationApprover)` calling `DelegationManager.modifyOperatorDetails()` for delegation approver updates - **M-04 Fix**: Same retry mechanism as M-02 allows subsequent calls to complete cleanup if initial call was gas-griefed ### Informational Severity - **I-02 Fix**: Added `DeallocateAttempted(bool success)` and `DeregisterAttempted(bool success)` events for off-chain monitoring - **I-03 Fix**: changed to `DepositExceedsMaxPerDeposit()` error for clearer messaging in `beforeAddShares()` - **I-04 Fix**: Added strategy support check in `lock()` via `AllocationManager.getStrategiesInOperatorSet()`, reverts with `StrategyNotSupportedByOperatorSet()` if unsupported - **I-05 Fix**: Added `@param arbitrator` NatSpec to VaultConfig struct - **I-06 Fix**: Changed `operatorSetRegistered()` to query `AllocationManager.isMemberOfOperatorSet()` directly **Result:** Improved protocol correctness and security for Duration Vaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.