Skip to content

perf: clear deallocation queue once per strategy in modifyAllocations #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MozirDmitriy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: clear deallocation queue once per strategy in modifyAllocations #1676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/contracts/core/AllocationManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ contract AllocationManager is
/// @inheritdoc IAllocationManagerActions
function modifyAllocations(
address operator,
AllocateParams[] memory params
AllocateParams[] calldata params
) external onlyWhenNotPaused(PAUSED_MODIFY_ALLOCATIONS) {
// Check that the caller is allowed to modify allocations on behalf of the operator
// We do not use a modifier to avoid `stack too deep` errors
Expand All @@ -91,6 +91,13 @@ contract AllocationManager is
operatorAllocationDelay = delay;
}

uint256 totalStrategies;
for (uint256 i = 0; i < params.length; i++) {
totalStrategies += params[i].strategies.length;
}
IStrategy[] memory seenStrategies = new IStrategy[](totalStrategies);
uint256 seenStrategiesCount;

for (uint256 i = 0; i < params.length; i++) {
require(params[i].strategies.length == params[i].newMagnitudes.length, InputArrayLengthMismatch());

Expand All @@ -110,7 +117,17 @@ contract AllocationManager is
// 1. If the operator has any pending deallocations for this strategy, clear them
// to free up magnitude for allocation. Fetch the operator's up to date allocation
// info and ensure there is no remaining pending modification.
_clearDeallocationQueue(operator, strategy, type(uint16).max);
bool alreadyCleared;
for (uint256 k = 0; k < seenStrategiesCount; ++k) {
if (seenStrategies[k] == strategy) {
alreadyCleared = true;
break;
}
}
if (!alreadyCleared) {
_clearDeallocationQueue(operator, strategy, type(uint16).max);
seenStrategies[seenStrategiesCount++] = strategy;
}

(StrategyInfo memory info, Allocation memory allocation) =
_getUpdatedAllocation(operator, operatorSet.key(), strategy);
Expand Down