-
Notifications
You must be signed in to change notification settings - Fork 453
feat: slashing commitments #1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ypatil12
merged 9 commits into
release-dev/slashing-ux-improvements
from
feat/alm-solution
Nov 6, 2025
Merged
feat: slashing commitments #1645
ypatil12
merged 9 commits into
release-dev/slashing-ux-improvements
from
feat/alm-solution
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadir-akhtar
reviewed
Oct 2, 2025
a457081 to
999b54b
Compare
bce9cbb to
c572ec5
Compare
4bf458a to
e32292e
Compare
eigenmikem
approved these changes
Oct 28, 2025
cd75057 to
13ea59b
Compare
nadir-akhtar
approved these changes
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Reviewed the code and tests, looks well covered.
feat: allow migration chore: gap chore: make opSets backwards compatible feat: add operatorSet creation; add tests test: setSlasher feat: add pending slasher introspection + tests test: add slasher tests test: slasher fix: require slasher to be zero address test: upgrade feat: migration script; migration event chore: update strat.sh docs: slashing commitments
fix: lavamoat zeus
Co-authored-by: Nadir Akhtar <[email protected]>
eb68e6f to
817eacc
Compare
e0297a4
into
release-dev/slashing-ux-improvements
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to solve the following use cases:
PermissionControlleractionsModifications:
The slasher permissions are set and stored in the
AllocationManagerinstead of thePermissionController. The slasher is initially set upon creation of the operatorSet.New functions:
updateSlasher: can set a new slasher on aALLOCATION_CONFIGURATION_DELAYblocks (17.5 days on mainnet)migrateSlasher: migrates the slasher address from thePermissionControllerto theAllocationManager. Can be migrated only once for a given operatorSet. This function will be called after the upgrade for all operatorSets. See the script in the script folder, which will eventually be added to the upgrade script.createOperatorSet: modified to take in a slasher address, which can immediately slash an operatorSet. The old function is still available and will be deprecated in Q2 2026. The old function automatically the slasher to the avs address.Old Functions:
slashOperatoris modified to not use thecheckCanCallmodifierWe have 1.9KB left in the ALM.
Result:
Stronger commitments.