Skip to content

fix: Add empty array check in StrategyManager strategy removal #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Add empty array check in StrategyManager strategy removal #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/contracts/core/StrategyManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ contract StrategyManager is
expiry: expiry
});
// Increment the nonce for the staker.
require(nonce < type(uint256).max, "NonceOverflow");
unchecked {
nonces[staker] = nonce + 1;
}
Expand Down Expand Up @@ -365,6 +366,10 @@ contract StrategyManager is
function _removeStrategyFromStakerStrategyList(address staker, IStrategy strategy) internal {
//loop through all of the strategies, find the right one, then replace
uint256 stratsLength = stakerStrategyList[staker].length;

// Additional safety check for empty array
require(stratsLength > 0, "EmptyStrategyList");

uint256 j = 0;
for (; j < stratsLength; ++j) {
if (stakerStrategyList[staker][j] == strategy) {
Expand Down