feat: multichain deployments #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We should only merge the Zeus upgrade script into the release branch |
ypatil12
reviewed
Jun 23, 2025
| function computeCrosschainUpgradeableProxyAddress( | ||
| address implementation, | ||
| address admin, | ||
| bytes11 salt |
Collaborator
There was a problem hiding this comment.
TODO: add deterministic salt per contract name. Discussed using FFI offline
ypatil12
reviewed
Jun 23, 2025
|
|
||
| bytes11 constant EMPTY_CONTRACT_SALT = bytes11(uint88(0xffffffffffffffffffffff)); | ||
|
|
||
| library CrosschainDeployLib { |
Collaborator
There was a problem hiding this comment.
Let's move this to script/releases
ypatil12
changed the base branch from
release-dev/multichain
to
feat/deploy-scripts
ypatil12
pushed a commit
that referenced
this pull request
Jun 28, 2025
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
ypatil12
pushed a commit
that referenced
this pull request
Jun 28, 2025
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
ypatil12
pushed a commit
that referenced
this pull request
Jun 28, 2025
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
ypatil12
pushed a commit
that referenced
this pull request
Jul 1, 2025
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
ypatil12
pushed a commit
that referenced
this pull request
Jul 1, 2025
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
ypatil12
pushed a commit
that referenced
this pull request
Jul 1, 2025
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
ypatil12
added a commit
that referenced
this pull request
Jul 1, 2025
**Motivation:** We need deploy scripts for multichain **Modifications:** Adds a `crossChainDeployLib` from: #1474. This library uses `createX` for deterministic deployments. In order to keep the same address on all `destinationChains`, we deploy contracts from the same multisig on each chain. Add `testnet-base-sepolia` to CI for deploy scripts. Adds a `deploy_globalRootConfirmerSet` script. This script initiates a global root confirmer set (ie. generator) and updates the `network.toml` file used in the deploy scripts. It is only intended to be used on `preprod` and `testnet`. To distinguish between a source and destination chain we add a `SOURCE_CHAIN: bool` and `DESTINATION_CHAIN: bool` to the Zeus Config. We skip parts of the deploy if a chain is not a source or destination. Deploys the contracts in 5 steps 1. `deploySourceChain.s.sol`: Deploys `KeyRegistrar`, `ReleaseManager`, `CrossChainRegistry`. 2. `deployDestinationChainProxies.s.sol`: Deploys _empty_ proxy contracts for `OperatorTableUpdater`, `BN254CertificateVerifier`, `ECDSACertificateVerifier`. _Note: in order to have deterministic proxies, we need to ensure the `initCode` is the same. Thus, the implementation is the same `emptyContract` and the proxyAdmin is initially the `multichainDeployerMultisig`_. 3. `deployDestinationChainImpls`: Deploys implementations using EOA 4. `instantiateDestinationChainProxies`: Upgrades the proxies to the actual implementations. Transfer proxy admin to the actual `proxyAdmin` 5. `configureCrossChainRegistry`: Updates the `crossChainRegistry` on the `SOURCE_CHAIN` to whitelist proper chainIds **Result:** Deploy scripts --------- Co-authored-by: clandestine.eth <[email protected]>
ypatil12
added a commit
that referenced
this pull request
Jul 1, 2025
**Motivation:** We need deploy scripts for multichain **Modifications:** Adds a `crossChainDeployLib` from: #1474. This library uses `createX` for deterministic deployments. In order to keep the same address on all `destinationChains`, we deploy contracts from the same multisig on each chain. Add `testnet-base-sepolia` to CI for deploy scripts. Adds a `deploy_globalRootConfirmerSet` script. This script initiates a global root confirmer set (ie. generator) and updates the `network.toml` file used in the deploy scripts. It is only intended to be used on `preprod` and `testnet`. To distinguish between a source and destination chain we add a `SOURCE_CHAIN: bool` and `DESTINATION_CHAIN: bool` to the Zeus Config. We skip parts of the deploy if a chain is not a source or destination. Deploys the contracts in 5 steps 1. `deploySourceChain.s.sol`: Deploys `KeyRegistrar`, `ReleaseManager`, `CrossChainRegistry`. 2. `deployDestinationChainProxies.s.sol`: Deploys _empty_ proxy contracts for `OperatorTableUpdater`, `BN254CertificateVerifier`, `ECDSACertificateVerifier`. _Note: in order to have deterministic proxies, we need to ensure the `initCode` is the same. Thus, the implementation is the same `emptyContract` and the proxyAdmin is initially the `multichainDeployerMultisig`_. 3. `deployDestinationChainImpls`: Deploys implementations using EOA 4. `instantiateDestinationChainProxies`: Upgrades the proxies to the actual implementations. Transfer proxy admin to the actual `proxyAdmin` 5. `configureCrossChainRegistry`: Updates the `crossChainRegistry` on the `SOURCE_CHAIN` to whitelist proper chainIds **Result:** Deploy scripts --------- Co-authored-by: clandestine.eth <[email protected]>
ypatil12
added a commit
that referenced
this pull request
Jul 7, 2025
**Motivation:** We need deploy scripts for multichain **Modifications:** Adds a `crossChainDeployLib` from: #1474. This library uses `createX` for deterministic deployments. In order to keep the same address on all `destinationChains`, we deploy contracts from the same multisig on each chain. Add `testnet-base-sepolia` to CI for deploy scripts. Adds a `deploy_globalRootConfirmerSet` script. This script initiates a global root confirmer set (ie. generator) and updates the `network.toml` file used in the deploy scripts. It is only intended to be used on `preprod` and `testnet`. To distinguish between a source and destination chain we add a `SOURCE_CHAIN: bool` and `DESTINATION_CHAIN: bool` to the Zeus Config. We skip parts of the deploy if a chain is not a source or destination. Deploys the contracts in 5 steps 1. `deploySourceChain.s.sol`: Deploys `KeyRegistrar`, `ReleaseManager`, `CrossChainRegistry`. 2. `deployDestinationChainProxies.s.sol`: Deploys _empty_ proxy contracts for `OperatorTableUpdater`, `BN254CertificateVerifier`, `ECDSACertificateVerifier`. _Note: in order to have deterministic proxies, we need to ensure the `initCode` is the same. Thus, the implementation is the same `emptyContract` and the proxyAdmin is initially the `multichainDeployerMultisig`_. 3. `deployDestinationChainImpls`: Deploys implementations using EOA 4. `instantiateDestinationChainProxies`: Upgrades the proxies to the actual implementations. Transfer proxy admin to the actual `proxyAdmin` 5. `configureCrossChainRegistry`: Updates the `crossChainRegistry` on the `SOURCE_CHAIN` to whitelist proper chainIds **Result:** Deploy scripts --------- Co-authored-by: clandestine.eth <[email protected]>
ypatil12
pushed a commit
that referenced
this pull request
Aug 1, 2025
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* **Modifications:** *Describe the modifications you've done.* **Result:** *After your change, what will change.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.