Skip to content

test: checkpoint with no added shares #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8sunyuan merged 3 commits into from
Mar 4, 2025
Merged

test: checkpoint with no added shares #1191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79dc598
test: demonstrating shares inflation bug
8sunyuan Feb 28, 2025
51f898f
fix: update test with the fix
8sunyuan Mar 4, 2025
254a8f1
chore: move test to other file
8sunyuan Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 87 additions & 6 deletions src/test/integration/tests/Slashed_Eigenpod_BC.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@ contract Integration_SlashedEigenpod_BC is IntegrationCheckUtils {
User staker;
IStrategy[] strategies;
uint[] initTokenBalances;
uint[] initDepositShares;
uint64 beaconBalanceGwei;
uint64 slashedGwei;
IERC20[] tokens;
uint40[] validators;
uint40[] slashedValidators;

function _init() internal override {
function _init() internal virtual override {
_configAssetTypes(HOLDS_ETH);
(staker, strategies, initTokenBalances) = _newRandomStaker();
(operator,,) = _newRandomOperator();
Expand All @@ -31,7 +34,7 @@ contract Integration_SlashedEigenpod_BC is IntegrationCheckUtils {
uint[] memory shares = _calculateExpectedShares(strategies, initTokenBalances);
staker.depositIntoEigenlayer(strategies, initTokenBalances);
check_Deposit_State(staker, strategies, shares);
uint40[] memory validators = staker.getActiveValidators();
validators = staker.getActiveValidators();

//Slash on Beacon chain
slashedValidators = _choose(validators);
Expand Down Expand Up @@ -106,7 +109,7 @@ contract Integration_SlashedEigenpod_BC is IntegrationCheckUtils {

(uint256[] memory withdrawableSharesAfter, uint256[] memory depositSharesAfter) = delegationManager.getWithdrawableShares(address(staker), strategies);
assertEq(depositSharesAfter[0], initDelegatableShares[0], "Deposit shares should reset to reflect slash(es)");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 100, "Withdrawable shares should equal deposit shares after withdrawal");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 1000, "Withdrawable shares should equal deposit shares after withdrawal");
Copy link
Copy Markdown
Contributor

@ypatil12 ypatil12 Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume this check is sanity? Since we do assert_Snap_Added_Staker_WithdrawableShares in the complete as shares check.

Copy link
Copy Markdown
Contributor Author

@8sunyuan 8sunyuan Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some instances where it was failing with a real delta of 103. Perhaps because my added contract is inheriting the other tests

}

function testFuzz_delegateSlashedStaker_slashedOperator(uint24 _random) public rand(_random) {
Expand Down Expand Up @@ -172,7 +175,7 @@ contract Integration_SlashedEigenpod_BC is IntegrationCheckUtils {

(uint256[] memory withdrawableSharesAfter, uint256[] memory depositSharesAfter) = delegationManager.getWithdrawableShares(address(staker), strategies);
assertEq(depositSharesAfter[0], delegatedShares[0], "Deposit shares should reset to reflect slash(es)");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 100, "Withdrawable shares should equal deposit shares after withdrawal");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 1000, "Withdrawable shares should equal deposit shares after withdrawal");
}

function testFuzz_delegateSlashedStaker_redelegate_complete(uint24 _random) public rand(_random){
Expand Down Expand Up @@ -208,7 +211,7 @@ contract Integration_SlashedEigenpod_BC is IntegrationCheckUtils {

(uint256[] memory withdrawableSharesAfter, uint256[] memory depositSharesAfter) = delegationManager.getWithdrawableShares(address(staker), strategies);
assertEq(depositSharesAfter[0], delegatedShares[0], "Deposit shares should reset to reflect slash(es)");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 100, "Withdrawable shares should equal deposit shares after withdrawal");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 1000, "Withdrawable shares should equal deposit shares after withdrawal");
}


Expand Down Expand Up @@ -257,7 +260,7 @@ contract Integration_SlashedEigenpod_BC is IntegrationCheckUtils {

(uint256[] memory withdrawableSharesAfter, uint256[] memory depositSharesAfter) = delegationManager.getWithdrawableShares(address(staker), strategies);
assertEq(depositSharesAfter[0], delegatedShares[0], "Deposit shares should reset to reflect slash(es)");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 100, "Withdrawable shares should equal deposit shares after withdrawal");
assertApproxEqAbs(withdrawableSharesAfter[0], depositSharesAfter[0], 1000, "Withdrawable shares should equal deposit shares after withdrawal");
}

function testFuzz_redeposit_queue_completeAsTokens(uint24 _random) public rand(_random){
Expand Down Expand Up @@ -641,3 +644,81 @@ contract Integration_Redelegate_SlashOperator_SlashEigenpod is Integration_Slash
check_VerifyWC_State(staker, newValidators, beaconBalanceAddedGwei);
}
}

contract Integration_SlashedEigenpod_BC_HalfSlash is Integration_SlashedEigenpod_BC {
using ArrayLib for *;

function _init() internal override {
_configAssetTypes(HOLDS_ETH);
(staker, strategies, initDepositShares) = _newRandomStaker();
(operator,,) = _newRandomOperator();
(avs,) = _newRandomAVS();

cheats.assume(initDepositShares[0] >= 64 ether);

// 1. start validators, advance epoch
(validators, beaconBalanceGwei) = staker.startValidators();
beaconChain.advanceEpoch_NoRewards();

// 2. deposit: verify wc
staker.verifyWithdrawalCredentials(validators);
check_VerifyWC_State(staker, validators, beaconBalanceGwei);

uint[] memory shares = _calculateExpectedShares(strategies, initDepositShares);
check_Deposit_State(staker, strategies, shares);

// 3. slash validators (half)
uint40[] memory slashedValidators = _choose(validators);
slashedGwei = beaconChain.slashValidators(slashedValidators, BeaconChainMock.SlashType.Half);
beaconChain.advanceEpoch_NoWithdrawNoRewards();

// 4. start/complete cp to reduce BCSF
staker.startCheckpoint();
staker.completeCheckpoint();
check_CompleteCheckpoint_WithSlashing_HandleRoundDown_State(staker, slashedValidators, slashedGwei);
}

/**
* @notice Test sets up an EigenPod which has a non-WAD BCSF. After queue withdrawing all depositShares
* which sets it to 0, they can then complete checkpoints repeatedly with 0 shares increase to increase the staker DSF each time
*/
function test_completeCP_withNoAddedShares(uint24 _rand) public rand(_rand) {
// 5. queue withdraw all depositShares having it set to 0
uint withdrawableSharesBefore = _getStakerWithdrawableShares(staker, strategies)[0];
Withdrawal[] memory withdrawals = staker.queueWithdrawals(strategies, initDepositShares);

// 6. advance epoch no rewards
// start/complete cp repeatedly with 0 shares increase to increase the staker DSF each time
for (uint256 i = 0; i < 10; i++) {
beaconChain.advanceEpoch_NoWithdrawNoRewards();
staker.startCheckpoint();
staker.completeCheckpoint();
}

// Staker deposit shares should be 0 from queue withdrawing all depositShares
// therefore the depositScalingFactor should also be reset WAD
assertEq(eigenPodManager.podOwnerDepositShares(address(staker)), 0);
assertEq(delegationManager.depositScalingFactor(address(staker), beaconChainETHStrategy), WAD);

// 7. deposit: can either verify wc or start/complete cp or complete the withdrawals as shares
_rollBlocksForCompleteWithdrawals(withdrawals);
staker.completeWithdrawalsAsShares(withdrawals);

// 8. delegateTo an operator
staker.delegateTo(operator);
// End state: staker and operator have much higher inflated withdrawable and delegated shares respectively
// The staker's withdrawable shares should be <= from withdrawable shares before (should be equal but could be less due to rounding)
uint withdrawableSharesAfter = _getStakerWithdrawableShares(staker, strategies)[0];
uint operatorShares = delegationManager.operatorShares(address(operator), strategies[0]);
assertLe(
withdrawableSharesAfter,
withdrawableSharesBefore,
"staker withdrawable shares should be <= from withdrawable shares before"
);
assertLe(
operatorShares,
withdrawableSharesBefore,
"operatorShares should be <= from withdrawable shares before"
);
}
}
Loading