Skip to content

Conversation

@0xrajath
Copy link
Collaborator

@0xrajath 0xrajath commented Feb 7, 2025

Motivation:

  1. Add a vscode settings json that uses the forge formatter for format on save
  2. Remove husky

@0xrajath 0xrajath self-assigned this Feb 7, 2025
@0xrajath 0xrajath marked this pull request as ready for review February 7, 2025 00:52
@ypatil12
Copy link
Collaborator

ypatil12 commented Feb 7, 2025

Removing husky gets rid of conventional commits?

@0xrajath
Copy link
Collaborator Author

0xrajath commented Feb 7, 2025

Removing husky gets rid of conventional commits?

We still have the commit lint in CI. Currently we no longer have a commitlint.js file in the repo so husky just keeps failing everytime I try to commit something. I believe @0xClandestine said that we can remove husky. But open to ideas.

@0xrajath 0xrajath merged commit 70302f0 into dev Feb 7, 2025
6 of 7 checks passed
@0xrajath 0xrajath deleted the rajath/vscode-settings branch February 7, 2025 15:36
ypatil12 pushed a commit that referenced this pull request Feb 19, 2025
* chore: remove husky

* chore: vscode settings json

* chore: cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants