Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rewards claim command #150

Merged
merged 22 commits into from
Jul 8, 2024
Merged

Add Rewards claim command #150

merged 22 commits into from
Jul 8, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Jul 3, 2024 •
edited
Loading

Fixes # .

What Changed?

  • Add rewards claim command

TODO

  • Add private key signer for simple testing - 88433c3
  • Add other signers for support a028392 (Fireblocks/Web3 in separate PR after this is merged)
  • Fix the env / network stuff 0e2e710
  • Implement Output flag
  • After a successful claim, log a message 3f4c90e
  • Wrap errors properly 5fd6def
  • Implement password with echo command for automation - this already works with the cli
  • Add better log messages while generating claims 3f4c90e
  • For non broadcast scenario, output a good message that can be used for someone to send tx themselves fc78a3d

Output when broadcast is disabled.
Screenshot 2024-07-03 at 10 57 03 PM

@shrimalmadhur shrimalmadhur force-pushed the madhur-elo-216-implement-rewards-claim-generation-as-part-of-el-cli branch 2 times, most recently from f8781fe to 822a613 Compare July 4, 2024 01:14
@shrimalmadhur shrimalmadhur changed the title init commit Add Rewards claim command Jul 4, 2024
@shrimalmadhur shrimalmadhur marked this pull request as ready for review July 4, 2024 01:14
@shrimalmadhur shrimalmadhur force-pushed the madhur-elo-216-implement-rewards-claim-generation-as-part-of-el-cli branch from f44b62e to 53bb0a7 Compare July 4, 2024 04:37
seanmcgary
seanmcgary reviewed Jul 8, 2024
View reviewed changes
pkg/rewards/claim.go Outdated Show resolved Hide resolved
seanmcgary
seanmcgary reviewed Jul 8, 2024
View reviewed changes
pkg/utils/constants.go Outdated Show resolved Hide resolved
@shrimalmadhur shrimalmadhur force-pushed the madhur-elo-216-implement-rewards-claim-generation-as-part-of-el-cli branch from d528422 to 0aeb8f1 Compare July 8, 2024 18:05
@shrimalmadhur shrimalmadhur merged commit 8ab1344 into master Jul 8, 2024
8 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur-elo-216-implement-rewards-claim-generation-as-part-of-el-cli branch July 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmcgary seanmcgary seanmcgary approved these changes

@nelsonijih nelsonijih Awaiting requested review from nelsonijih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @seanmcgary