[payment] prune reservation periods and ondemand payments #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To avoid db from infinitely growing, we prune reservations and ondemand records
reservations are pruned periodically with a goroutine similar to refreshing onchain state, as it operates based on time. The frequency is set as a configuration to the offchain store
ondemands are pruned every time a ondemand request is served, with a hardcoded constant which is 100 for each account, this can also be a configuration
also contains some renaming of
binRecord
toreservationPeriodRecord
, and refactoringrefreshOnchainState
functionChecks