-
Notifications
You must be signed in to change notification settings - Fork 211
[v2] eth address as account id #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e5c5b52
temp: eth address as account id
hopeyen fa32683
fix: request accountID updated to use address
hopeyen 5007d10
fix: auth uses accountID as eth address
hopeyen 1017692
fix: v1 update for accountID
hopeyen b18a4e5
refactor: undo chanages to v1
hopeyen 719821b
fix: account id in payment setup
hopeyen 196085c
refactor: check Address type not string
hopeyen 6d789e8
feat: more signer test coverage
hopeyen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package v2 | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestGetAccountID(t *testing.T) { | ||
// Test case with known private key and expected account ID | ||
// privateKey := "73ae7e3a40b59caacb1cda8fa04f4e7fa5bb2b37101f9f3506290c201f57bf7b" | ||
privateKey := "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcded" | ||
expectedAccountID := "0x1aa8226f6d354380dDE75eE6B634875c4203e522" | ||
|
||
// Create signer instance | ||
signer := NewLocalBlobRequestSigner(privateKey) | ||
|
||
// Get account ID | ||
accountID, err := signer.GetAccountID() | ||
assert.NoError(t, err) | ||
assert.Equal(t, expectedAccountID, accountID) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we're comparing strings, but this will fail if
accountID
isn't checksummed string.I think it's safer to convert
accountID
to common.Address (common.HexToAddress()) and compare bytearrays usingAddress.Cmp()
Do we have a test capturing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use address type.
We have auth_test that check for authenticating the requests, but not as specific as whether it is checksum or not.