V2 contract testing #1032
Open
V2 contract testing #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
reviewed
Dec 19, 2024
| @@ -96,7 +96,7 @@ contract EigenDABlobVerifier is IEigenDABlobVerifier { | |||
| blobVerificationProof, | |||
| nonSignerStakesAndSignature, | |||
| getDefaultSecurityThresholdsV2(), | |||
| quorumNumbersRequired() | |||
| blobVerificationProof.blobCertificate.blobHeader.quorumNumbers | |||
There was a problem hiding this comment.
it's already taking blobVerificationProof as input in L96, so looks like we could just reuse that in _verifyBlobV2ForQuorums
There was a problem hiding this comment.
yes but I do want to leave this field in the internal function open such that the quorums you want to check against can be passed in separately from the proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for V2 contracts