Read Authority
field in Cloudflare/Google DNS response
#56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some DNS queries, such as
type=NS
whenname=subdomain.example.com
, the response from Cloudflare/Google contains anAuthority
field instead ofAnswer
.This change reads the
Authority
field if present in order to fix a bug withgetAllDNSRecords("subdomain.example.com", { resolver: "cloudflare-dns" })
. Currently, instead of returning the records associated with the subdomain, it incorrectly returns an empty array because it does not read theAuthority
field in the NS records response. As a result,nsRecords.length = 0
which fails thensRecords.length
check here, and no requests for additional records are made.