Skip to content

Fix: Clear plotlyReadyCallbacks to prevent old callbacks from executing. #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Fix: Clear plotlyReadyCallbacks to prevent old callbacks from executing. #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Plotly.Blazor.Generator/Plotly.Blazor.Generator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<None Include="..\Plotly.Blazor\wwwroot\plotly-basic-3.0.0.min.js" Link="src\wwwroot\plotly-basic-3.0.0.min.js">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="..\Plotly.Blazor\wwwroot\plotly-interop-6.0.0.js" Link="src\wwwroot\plotly-interop-6.0.0.js">
<None Include="..\Plotly.Blazor\wwwroot\plotly-interop-6.0.1.js" Link="src\wwwroot\plotly-interop-6.0.1.js">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="..\Plotly.Blazor\_Imports.razor" Link="src\_Imports.razor">
Expand Down
2 changes: 1 addition & 1 deletion Plotly.Blazor/PlotlyJsInterop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace Plotly.Blazor;
/// </summary>
public class PlotlyJsInterop
{
private const string InteropPath = "./_content/Plotly.Blazor/plotly-interop-6.0.0.js";
private const string InteropPath = "./_content/Plotly.Blazor/plotly-interop-6.0.1.js";
private const string PlotlyPath = "./_content/Plotly.Blazor/plotly-3.0.0.min.js";
private const string PlotlyBasicPath = "./_content/Plotly.Blazor/plotly-basic-3.0.0.min.js";

Expand Down
1 change: 1 addition & 0 deletions ...ly.Blazor/wwwroot/plotly-interop-6.0.0.js → ...ly.Blazor/wwwroot/plotly-interop-6.0.1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export async function importScript(id, scriptUrl) {
scriptCache.set(id, scriptUrl);
plotlyReady = true;
plotlyReadyCallbacks.forEach(callback => callback());
plotlyReadyCallbacks.length = 0;
resolve();
};
script.onerror = (error) => {
Expand Down