Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[desktop app] Can't submit Dropbox login credentials #328

Closed
WTurunen opened this issue Dec 16, 2015 · 13 comments
Closed

[desktop app] Can't submit Dropbox login credentials #328

WTurunen opened this issue Dec 16, 2015 · 13 comments

Comments

@WTurunen
Copy link

Syncing to Dropbox app, I can't sign in to Dropbox. The Sign in button remains disabled when the email address and password are entered.

Also the placeholder text stays while editing the fields.

login

@wwebfor
Copy link
Member

wwebfor commented Dec 16, 2015

What OS do you use?

Maybe I'm wrong, bug judging from the screenshot, it seems like Dropbox "Sign in" page hasn't finished loading.

@WTurunen
Copy link
Author

I'm on Windows 10 64bit.

I've waited for several minutes with a 100M connection and the button remains disabled. The Dropbox-icon and forgot password links work.

@wwebfor
Copy link
Member

wwebfor commented Dec 16, 2015

I see. We will try to figure out what is causing the problem later. Thanks for your bug report.

@claell
Copy link

claell commented Dec 16, 2015

It seems like the fields are not recognized as filled in. You could try to use tab to navigate from one field to another instead of using the mouse. Maybe then it is recognized?

@WTurunen
Copy link
Author

I tried using tab, as I usually do, and with mouse, but no changes - the button remains disabled either way.

@claell
Copy link

claell commented Dec 16, 2015

Alright, thanks for trying.

@wwebfor wwebfor added the bug label Dec 17, 2015
@wwebfor wwebfor added this to the 1. Refactor and fix bugs milestone Dec 17, 2015
@arulk
Copy link

arulk commented Dec 27, 2015

I have the same issue but on Mac OSX . I am unable to enter my dropbox authorization credentials.

@valvin1
Copy link

valvin1 commented Jan 4, 2016

I have the same on Linux Ubuntu 15.10 64bits but only on desktop version. Dropbox sync is working on web version.

@zweicoder
Copy link
Contributor

@wwebfor Having experienced this problem I spent some time working on it to find out why it happens. AssertionError: path must be a string was thrown by the Dropbox OAuth page, meaning the Javascript stuff being loaded by the site was conflicting with Electron / Node's require method.

Since it's loaded by an external site we can't inject stuff to override the require methods as is being done in app/index.html. The simplest way is to disable node-integration altogether when constructing BrowserWindow by setting it to false (Not sure whether this breaks anything but the tests pass..)

I have also made an Electron AuthDriver that only disables node-integration on the OAuth page, although you will have to add https://www.dropbox.com/1/oauth2/redirect_receiver to your redirect URI in the Dropbox Console.

Tell me if either one of these is fine and I'll send in a PR if needed :)

@wwebfor
Copy link
Member

wwebfor commented Jan 4, 2016

@zweicoder we left node-integration enabled because of the issue #262, so it is preferable to have access to Nodejs API.

I guess the safest choice is to disable node-integration on all pages except for the pages which contain strings like localhost or file://. Although, I am not sure if it is possible to do that.

@wwebfor wwebfor closed this as completed in 3205aaa Jan 5, 2016
wwebfor added a commit that referenced this issue Jan 5, 2016
Preload to prevent breaking external pages in Electron. Fixes #328, #351
@mmdavid
Copy link

mmdavid commented Feb 16, 2018

Hi. Did you fix this bug? I'am having the same problem. Papers3 Version 3.3.3 (361) on mac OSX 10.13.1

@ajn123
Copy link

ajn123 commented Jun 21, 2019

Still have this same problem on Mac OSX

@funilrys
Copy link
Contributor

Hi @ajn123 @mmdavid @zweicoder @valvin1 @arulk @claell @WTurunen

Unfortunately, this issue will never be fixed here.

Please report to #971 (comment) for the current state of this project and https://github.com/encryptic-team/encryptic for the future of this project.

Have a nice day/night.

Cheers,
Nissar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants